Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating S3 configuration completion #52

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Updating S3 configuration completion #52

merged 1 commit into from
Nov 22, 2018

Conversation

coreydaley
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 3, 2018
@coreydaley
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2018
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 15, 2018
@bparees
Copy link
Contributor

bparees commented Nov 16, 2018

@jupierce watch this space for AWS S3 storage setup for the registry.

@coreydaley coreydaley changed the title [WIP] Updating S3 configuration completion Updating S3 configuration completion Nov 17, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2018
@coreydaley
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2018
@coreydaley
Copy link
Member Author

@legionus @dmage @bparees ptal
I still need to write test(s) but please take a look at what I have done thus far.

@coreydaley
Copy link
Member Author

/assign @legionus @dmage

bparees
bparees requested changes Nov 19, 2018
View reviewed changes
pkg/clusterconfig/clusterconfig.go Outdated Show resolved Hide resolved
pkg/clusterconfig/clusterconfig.go Outdated Show resolved Hide resolved
pkg/clusterconfig/clusterconfig.go Outdated Show resolved Hide resolved
pkg/clusterconfig/clusterconfig.go Outdated Show resolved Hide resolved
pkg/storage/gcs/gcs.go Outdated Show resolved Hide resolved
pkg/storage/s3/s3.go Outdated Show resolved Hide resolved
pkg/storage/s3/s3.go
if len(d.Config.Region) == 0 {
d.Config.Region = s3cfg.Storage.S3.Region
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment on the bucket creation logic below:

You need to ensure that on re-sync, we are making sure the bucket exists. That means a few things:

  1. Adding a condition on the registry resource that indicates when we have successfully created the bucket (we should not be deploying the registry until we are sure we created the bucket)
  2. a mechanism for ensuring that if the S3 bucket name changed, the condition is cleared until we create the new bucket.

this can be a follow up but i don't consider the s3 feature complete until we have these things.

pkg/storage/util/util.go Outdated Show resolved Hide resolved
@bparees bparees self-assigned this Nov 19, 2018
dmage
dmage reviewed Nov 20, 2018
View reviewed changes
test/e2e/aws_test.go Outdated Show resolved Hide resolved
@openshift-bot openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 20, 2018
@coreydaley
Copy link
Member Author

/retest

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 21, 2018
@coreydaley
Copy link
Member Author

/retest

bparees
bparees reviewed Nov 21, 2018
View reviewed changes
pkg/storage/storage.go Outdated Show resolved Hide resolved
bparees
bparees reviewed Nov 21, 2018
View reviewed changes
pkg/util/util.go Outdated Show resolved Hide resolved
@coreydaley
Copy link
Member Author

/retest

3 similar comments
@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

/retest

1 similar comment
@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

@bparees ptal

@bparees
Copy link
Contributor

bparees commented Nov 22, 2018

it looks good to me, but i'd like @dmage or @legionus to give it a once over as well.

@legionus i'd prefer to merge this before your refactor that does away w/ the SDK. I know that makes for more work for your refactor, but getting AWS storage working is critical right now.

@bparees bparees mentioned this pull request Nov 22, 2018
Closed
@legionus
Copy link
Contributor

legionus commented Nov 22, 2018 •
edited
Loading

@bparees I'm sad to hear that. ok, I will spend more time with rebase. as you wish.

@bparees
Copy link
Contributor

bparees commented Nov 22, 2018

@bparees I sad to hear that. ok, I will spend more time with rebase. as you wish.

yes i feel badly about it, thank you for understanding.

@legionus
Copy link
Contributor

yes i feel badly about it, thank you for understanding.

No. I do not understand, but it does not matter.

@bparees
Copy link
Contributor

bparees commented Nov 22, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, coreydaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2018
@openshift-merge-robot openshift-merge-robot merged commit fbe5a97 into openshift:master Nov 22, 2018
@coreydaley coreydaley deleted the s3_configuration_completion branch August 14, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmage dmage dmage left review comments

@bparees bparees bparees requested changes

@deads2k deads2k Awaiting requested review from deads2k

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@dmage dmage

@legionus legionus

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@coreydaley @bparees @legionus @openshift-ci-robot @dmage @openshift-bot @openshift-merge-robot