Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IR-119: Support IgnoreInvalidImageReferences #584

Merged
merged 3 commits into from Aug 1, 2020
Merged

IR-119: Support IgnoreInvalidImageReferences #584

merged 3 commits into from Aug 1, 2020

Conversation

dmage
Copy link
Member

@dmage dmage commented Jul 31, 2020

When the image pruner's spec.ignoreInvalidImageReferences is true, the pruner should be run with --ingore-invalid-refs=true.

This option is enabled by default for new instances.

See also openshift/api#708.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2020
bparees
bparees reviewed Jul 31, 2020
View reviewed changes
test/e2e/pruner_test.go
suspend := false
cr.Spec.Suspend = &suspend
cr.Spec.Schedule = "* * * * *"
cr.Spec.IgnoreInvalidImageReferences = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have an inverse test? (ensures the arg is not passed, or is passed w/ a value of false, when this is not set?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now I have, fixed

@dmage
Support IgnoreInvalidImageReferences
3628902 
When the image pruner's spec.ignoreInvalidImageReferences is true, the
pruner should be run with --ingore-invalid-refs=true.

This option is enabled by default for new instances.
@dmage
Copy link
Member Author

dmage commented Jul 31, 2020

/retest

@bparees
Copy link
Contributor

bparees commented Jul 31, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, dmage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dmage
Copy link
Member Author

dmage commented Jul 31, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8eb457b into openshift:master Aug 1, 2020
@dmage dmage mentioned this pull request Aug 3, 2020
Closed
@ricardomaraschini
Copy link
Contributor

@dmage aren't we planning to backport this to release-4.5 ? See https://bugzilla.redhat.com/show_bug.cgi?id=1852501#c39

@dmage
Copy link
Member Author

dmage commented Sep 7, 2020

@ricardomaraschini, no, we don't backport API changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees bparees left review comments

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dmage @bparees @openshift-ci-robot @openshift-bot @ricardomaraschini @openshift-merge-robot