New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IR-119: Support IgnoreInvalidImageReferences #584
IR-119: Support IgnoreInvalidImageReferences #584
Conversation
suspend := false | ||
cr.Spec.Suspend = &suspend | ||
cr.Spec.Schedule = "* * * * *" | ||
cr.Spec.IgnoreInvalidImageReferences = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have an inverse test? (ensures the arg is not passed, or is passed w/ a value of false, when this is not set?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now I have, fixed
When the image pruner's spec.ignoreInvalidImageReferences is true, the pruner should be run with --ingore-invalid-refs=true. This option is enabled by default for new instances.
8f99fa9
to
3628902
Compare
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, dmage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
@dmage aren't we planning to backport this to release-4.5 ? See https://bugzilla.redhat.com/show_bug.cgi?id=1852501#c39 |
@ricardomaraschini, no, we don't backport API changes |
When the image pruner's spec.ignoreInvalidImageReferences is true, the pruner should be run with --ingore-invalid-refs=true.
This option is enabled by default for new instances.
See also openshift/api#708.