Removed shared process namespace #587
Conversation
As we don't have two containers running on this POD anymore there is no need to have this shared namespace.
openshift-ci-robot
added
the
approved
|
/assign @dmage |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmage, ricardomaraschini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
| @@ -17,7 +17,6 @@ spec: | |||
| name: cluster-image-registry-operator | |||
| spec: | |||
| serviceAccountName: cluster-image-registry-operator | |||
| shareProcessNamespace: true | |||
There was a problem hiding this comment.
Kubernetes API for this property defaults to false, but the cluster-version operator treats unset pointers in manifests as "operator maintainers have no opinion". If you want to actually clear this, you should add an explicit shareProcessNamespace. If you are fine with existing clusters rolling forward with shareProcessNamespace: true, then just removing it like you do in this PR is fine. Or we can revisit the CVO's merge logic for this particular pointer field. Thoughts?
There was a problem hiding this comment.
Thanks for the heads up. I will create a PR to set this to false, I think it is better to keep enabled only features we actually use.
As we don't have two containers running on this POD anymore there is no
need to have this shared namespace.