Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed shared process namespace #587

Merged
merged 1 commit into from Aug 5, 2020
Merged

Removed shared process namespace #587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion manifests/07-operator.yaml
View file
Open in desktop
Expand Up @@ -17,7 +17,6 @@ spec:
name: cluster-image-registry-operator
spec:
serviceAccountName: cluster-image-registry-operator
shareProcessNamespace: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubernetes API for this property defaults to false, but the cluster-version operator treats unset pointers in manifests as "operator maintainers have no opinion". If you want to actually clear this, you should add an explicit shareProcessNamespace. If you are fine with existing clusters rolling forward with shareProcessNamespace: true, then just removing it like you do in this PR is fine. Or we can revisit the CVO's merge logic for this particular pointer field. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up. I will create a PR to set this to false, I think it is better to keep enabled only features we actually use.

priorityClassName: system-cluster-critical
nodeSelector:
node-role.kubernetes.io/master: ""
Expand Down