-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.7] Bug 1955176: Setting user provided tags on bucket creation #682
[release-4.7] Bug 1955176: Setting user provided tags on bucket creation #682
Conversation
I also had to bump k8s.io/* to 0.20.0 as I noticed that the version in release-4.7 has also been bumped to this version: https://github.com/openshift/api/blob/release-4.7/go.mod#L10-L13
OpenShift now supports users providing custom AWS tags to be set in all created objects. This PR sets users provided tags, as per enhancement proposal, only when the bucket is created by the operator. Again, as per enhancement proposal, already existing buckets are not updated if user changes tags at Infrastructure level.
Adds an unit test to check s3 driver is creating user provided tags when creating a bucket.
We have two properties that implement Cronjobs(): V1 and V1beta1. As we have been using v1beta1 across our codebase this PR silences a lint complain by being specific about which function we want to call.
@ricardomaraschini: This pull request references Bugzilla bug 1955176, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@ricardomaraschini: This pull request references Bugzilla bug 1955176, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Validate custom tag are created on S3 bucket. 4.7.0-0.ci.test-2021-04-30-024210-ci-ln-yic2712 /label qe-approved |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmage, ricardomaraschini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/bugzilla refresh |
@bparees: This pull request references Bugzilla bug 1955176, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@ricardomaraschini: All pull requests linked via external trackers have merged: Bugzilla bug 1955176 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Due to conflicts this is a manual backport of #679
OpenShift now supports users providing custom AWS tags to be set in all created objects. This PR sets users provided tags, as per enhancement proposal, only when the bucket is created by the operator. Again, as per enhancement proposal, already existing buckets are not updated if user changes tags at Infrastructure level.
Enhancement proposal: openshift/enhancements#706
API changes: openshift/api#864