Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Bug 1955176: Setting user provided tags on bucket creation #682

Merged
merged 5 commits into from Apr 30, 2021
Merged

[release-4.7] Bug 1955176: Setting user provided tags on bucket creation #682

merged 5 commits into from Apr 30, 2021

Conversation

ricardomaraschini
Copy link
Contributor

@ricardomaraschini ricardomaraschini commented Apr 29, 2021 •
edited

Due to conflicts this is a manual backport of #679

OpenShift now supports users providing custom AWS tags to be set in all created objects. This PR sets users provided tags, as per enhancement proposal, only when the bucket is created by the operator. Again, as per enhancement proposal, already existing buckets are not updated if user changes tags at Infrastructure level.

Enhancement proposal: openshift/enhancements#706
API changes: openshift/api#864

@ricardomaraschini
Bumping openshift/api for release-4.7 branch
edeb034 
I also had to bump k8s.io/* to 0.20.0 as I noticed that the version in
release-4.7 has also been bumped to this version:

https://github.com/openshift/api/blob/release-4.7/go.mod#L10-L13
@ricardomaraschini
Setting user provided tags on bucket creation
afbead2 
OpenShift now supports users providing custom AWS tags to be set in all
created objects. This PR sets users provided tags, as per enhancement
proposal, only when the bucket is created by the operator.

Again, as per enhancement proposal, already existing buckets are not
updated if user changes tags at Infrastructure level.
@ricardomaraschini
Adding test for user tags
bf1a2ae 
Adds an unit test to check s3 driver is creating user provided tags when
creating a bucket.
@ricardomaraschini
Improve logging around bucket tagging process
f5aac8e
@ricardomaraschini
Fix lint by being specific about CronJobs version
c336bd9 
We have two properties that implement Cronjobs(): V1 and V1beta1. As we
have been using v1beta1 across our codebase this PR silences a lint
complain by being specific about which function we want to call.
@ricardomaraschini ricardomaraschini changed the title Setting user provided tags on bucket creation [release-4.7] Bug XXXXXX: Setting user provided tags on bucket creation Apr 29, 2021
@ricardomaraschini ricardomaraschini changed the title [release-4.7] Bug XXXXXX: Setting user provided tags on bucket creation [release-4.7] Bug 1955176: Setting user provided tags on bucket creation Apr 29, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 29, 2021
@openshift-ci-robot
Copy link
Contributor

@ricardomaraschini: This pull request references Bugzilla bug 1955176, which is invalid:

  • expected dependent Bugzilla bug 1954095 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1955176: Setting user provided tags on bucket creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@ricardomaraschini: This pull request references Bugzilla bug 1955176, which is invalid:

  • expected dependent Bugzilla bug 1954095 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1955176: Setting user provided tags on bucket creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xiuwang
Copy link

xiuwang commented Apr 30, 2021

Validate custom tag are created on S3 bucket. 4.7.0-0.ci.test-2021-04-30-024210-ci-ln-yic2712
Set image registry operator Managed->Removed->Managed, S3 bucket with tags are updated as the change.

/label qe-approved

@openshift-ci-robot openshift-ci-robot added the qe-approved Signifies that QE has signed off on this PR label Apr 30, 2021
@ricardomaraschini
Copy link
Contributor Author

/retest

@dmage
Copy link
Member

dmage commented Apr 30, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dmage,ricardomaraschini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees
Copy link
Contributor

bparees commented Apr 30, 2021

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 30, 2021
@openshift-ci-robot
Copy link
Contributor

@bparees: This pull request references Bugzilla bug 1955176, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1954095 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1954095 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @wzheng1

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 30, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3cbefc7 into openshift:release-4.7 Apr 30, 2021
@openshift-ci-robot
Copy link
Contributor

@ricardomaraschini: All pull requests linked via external trackers have merged:

Bugzilla bug 1955176 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1955176: Setting user provided tags on bucket creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzheng1 wzheng1 Awaiting requested review from wzheng1

Assignees

@dmage dmage

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ricardomaraschini @openshift-ci-robot @xiuwang @dmage @openshift-bot @bparees @openshift-merge-robot