New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: Dump build information on failure #711
e2e: Dump build information on failure #711
Conversation
/lgtm |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/hold I think the build pod itself needs to be dumped. We hit the failure but it is hard to tell why the build is not trusting the internal registry. |
/retest |
1 similar comment
/retest |
If the test build fails, dump relevant build information to the log.
8011a19
to
42ed917
Compare
/retest |
2 similar comments
/retest |
/retest |
@dmage I see a lot of failures on the |
@adambkaplan it was broken, but 4 days ago we merged a fix for it. TestImageRegistryRemovedWithImages is flaky and it's exactly the test you're adding debug info to. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold cancel
Build pod info is now dumped on failure.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, dmage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No customer facing changes. It shouldn't change CI pass rate, so no actions from QE are required. |
If the test build fails, dump relevant build information to the log.