Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Dump build information on failure #711

Merged

Conversation

adambkaplan
Copy link
Contributor

If the test build fails, dump relevant build information to the log.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2021
@dmage
Copy link
Member

dmage commented Aug 23, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@adambkaplan
Copy link
Contributor Author

/hold

I think the build pod itself needs to be dumped. We hit the failure but it is hard to tell why the build is not trusting the internal registry.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm Indicates that a PR is ready to be merged. labels Aug 23, 2021
@adambkaplan
Copy link
Contributor Author

/retest

1 similar comment
@adambkaplan
Copy link
Contributor Author

/retest

If the test build fails, dump relevant build information to the log.
@adambkaplan
Copy link
Contributor Author

/retest

2 similar comments
@adambkaplan
Copy link
Contributor Author

/retest

@adambkaplan
Copy link
Contributor Author

/retest

@adambkaplan
Copy link
Contributor Author

@dmage I see a lot of failures on the e2e-aws-operator job - is this test broken?

@dmage
Copy link
Member

dmage commented Nov 19, 2021

@adambkaplan it was broken, but 4 days ago we merged a fix for it. TestImageRegistryRemovedWithImages is flaky and it's exactly the test you're adding debug info to.

@dmage
Copy link
Member

dmage commented Nov 19, 2021

/retest

Copy link
Contributor Author

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

Build pod info is now dumped on failure.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2021
@dmage
Copy link
Member

dmage commented Nov 25, 2021

/lgtm
/approve docs-approved
/approve px-approved

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, dmage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dmage
Copy link
Member

dmage commented Nov 25, 2021

No customer facing changes.
/label docs-approved
/label px-approved

It shouldn't change CI pass rate, so no actions from QE are required.
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Nov 25, 2021
@openshift-merge-robot openshift-merge-robot merged commit 198b7a2 into openshift:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants