Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-3974: check for nil pointer before dereferencing #814

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

flavianmissi
Copy link
Member

a customer reported seeing this on OCP 4.10 - not sure why it hasn't shown up before tbh

@flavianmissi
Copy link
Member Author

/assign @dmage

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2022
@flavianmissi
Copy link
Member Author

/retest

@flavianmissi
Copy link
Member Author

/test e2e-aws-operator

1 similar comment
@flavianmissi
Copy link
Member Author

/test e2e-aws-operator

@dmage
Copy link
Contributor

dmage commented Nov 14, 2022

@flavianmissi please add the Jira ticket to the title

@flavianmissi
Copy link
Member Author

@dmage there is no jira ticket - do we require one to merge?

@dmage
Copy link
Contributor

dmage commented Nov 21, 2022

@flavianmissi yes, for bug fixes we need a BZ or a Jira bug, for new features we need a Jira story.

@flavianmissi flavianmissi changed the title pkg/operator: check for nil pointer before dereferencing OCPBUGS-3974: check for nil pointer before dereferencing Nov 22, 2022
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 22, 2022
@openshift-ci-robot
Copy link
Contributor

@flavianmissi: This pull request references Jira Issue OCPBUGS-3974, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xiuwang

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

a customer reported seeing this on OCP 4.10 - not sure why it hasn't shown up before tbh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from xiuwang November 22, 2022 09:57
@flavianmissi
Copy link
Member Author

fixed, PTAL @dmage

@dmage
Copy link
Contributor

dmage commented Nov 22, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4ec6473 and 2 for PR HEAD 4a429cf in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0ad119b and 1 for PR HEAD 4a429cf in total

@xiuwang
Copy link

xiuwang commented Nov 23, 2022

Verified this issue on 4.12.0-0.ci.test-2022-11-23-082726-ci-ln-g4z1jjk-latest
when set imagepruner 'spec.suspend' to null , registry operator pod is running well, has no restart issue.

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 23, 2022
@xiuwang
Copy link

xiuwang commented Nov 23, 2022

/test e2e-aws-operator

@flavianmissi
Copy link
Member Author

/test e2e-aws-ovn-upgrade

1 similar comment
@xiuwang
Copy link

xiuwang commented Nov 24, 2022

/test e2e-aws-ovn-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2022

@flavianmissi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 115d07e into openshift:master Nov 24, 2022
@openshift-ci-robot
Copy link
Contributor

@flavianmissi: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-3974 has been moved to the MODIFIED state.

In response to this:

a customer reported seeing this on OCP 4.10 - not sure why it hasn't shown up before tbh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants