-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-3974: check for nil pointer before dereferencing #814
OCPBUGS-3974: check for nil pointer before dereferencing #814
Conversation
/assign @dmage |
/retest |
/test e2e-aws-operator |
1 similar comment
/test e2e-aws-operator |
@flavianmissi please add the Jira ticket to the title |
@dmage there is no jira ticket - do we require one to merge? |
@flavianmissi yes, for bug fixes we need a BZ or a Jira bug, for new features we need a Jira story. |
@flavianmissi: This pull request references Jira Issue OCPBUGS-3974, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3852146
to
4a429cf
Compare
fixed, PTAL @dmage |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmage, flavianmissi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Verified this issue on 4.12.0-0.ci.test-2022-11-23-082726-ci-ln-g4z1jjk-latest /label qe-approved |
/test e2e-aws-operator |
/test e2e-aws-ovn-upgrade |
1 similar comment
/test e2e-aws-ovn-upgrade |
@flavianmissi: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@flavianmissi: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-3974 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a customer reported seeing this on OCP 4.10 - not sure why it hasn't shown up before tbh