Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-17882: Add rbac permission IDMS, ITMS #891

Merged
merged 1 commit into from Aug 18, 2023

Conversation

QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Aug 4, 2023

Fix the permission failure caused by openshift/image-registry#346

@QiWang19
Copy link
Member Author

QiWang19 commented Aug 4, 2023

/retest-required

@QiWang19
Copy link
Member Author

QiWang19 commented Aug 4, 2023

@dmage @stbenjam PTAL

@QiWang19 QiWang19 force-pushed the idms-role branch 2 times, most recently from 9b2ffda to a86110d Compare August 8, 2023 17:43
@QiWang19
Copy link
Member Author

QiWang19 commented Aug 8, 2023

@dmage @stbenjam PTAL

Signed-off-by: Qi Wang <qiwan@redhat.com>
@flavianmissi
Copy link
Member

/lgtm
Does this need to be test together with openshift/image-registry#375 ?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, QiWang19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@QiWang19
Copy link
Member Author

openshift/image-registry#375 will rerun the test after this patch.

@flavianmissi
Copy link
Member

this is not user facing.
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Aug 17, 2023
@QiWang19
Copy link
Member Author

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 17, 2023
@QiWang19
Copy link
Member Author

/label jira/valid-bug

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2023

@QiWang19: Can not set label jira/valid-bug: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers openshift-release-oversight]

In response to this:

/label jira/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@QiWang19 QiWang19 changed the title Add rbac permission IDMS, ITMS [OCPBUGS-17882] Add rbac permission IDMS, ITMS Aug 17, 2023
@QiWang19 QiWang19 changed the title [OCPBUGS-17882] Add rbac permission IDMS, ITMS OCPBUGS-17882: Add rbac permission IDMS, ITMS Aug 17, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 17, 2023
@openshift-ci-robot
Copy link
Contributor

@QiWang19: This pull request references Jira Issue OCPBUGS-17882, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fix the permission failure caused by openshift/image-registry#346

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 17, 2023
@QiWang19
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 17, 2023
@openshift-ci-robot
Copy link
Contributor

@QiWang19: This pull request references Jira Issue OCPBUGS-17882, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4e87ffc and 2 for PR HEAD 2ec6716 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2023

@QiWang19: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ovirt-sdn a86110d link false /test e2e-ovirt-sdn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@QiWang19
Copy link
Member Author

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 37b7319 into openshift:master Aug 18, 2023
9 checks passed
@openshift-ci-robot
Copy link
Contributor

@QiWang19: Jira Issue OCPBUGS-17882: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17882 has been moved to the MODIFIED state.

In response to this:

Fix the permission failure caused by openshift/image-registry#346

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants