OCPBUGS-17975: Support both icsp and idms

[QiWang19]

Reopen #346 Support both icsp and idms as openshift/cluster-image-registry-operator#891 will fix the rbac permission issue.

[flavianmissi]

/retest

[flavianmissi]

/retest

[flavianmissi]

/retest

[QiWang19]

/retest

[QiWang19]

/retest

[QiWang19]

E0816 11:45:20.800614       1 simplelookupicsp.go:56] unable to list IDMS config: imagedigestmirrorsets.config.openshift.io is forbidden: User "system:serviceaccount:openshift-image-registry:registry" cannot list resource "imagedigestmirrorsets" in API group "config.openshift.io" at the cluster scope

the above error does not appear in e2e-metal-ipi-ovn-ipv6 test: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_image-registry/375/pull-ci-openshift-image-registry-master-e2e-metal-ipi-ovn-ipv6/1692131417183490048/artifacts/e2e-metal-ipi-ovn-ipv6/gather-extra/artifacts/pods/openshift-image-registry_image-registry-7477846d57-bcj24_registry.log

[openshift-ci]

@QiWang19: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[QiWang19]

@flavianmissi PTAL

[flavianmissi]

/lgtm
this will have to go on 4.15 though - 4.14 (master) is currently bugfix only afaik

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, QiWang19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [flavianmissi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[flavianmissi]

@QiWang19 is your team handling docs for this or do we want to IR docs involved? similar question regarding PX, do you have a PX contact to give the px-approved label here?

[QiWang19]

@QiWang19 is your team handling docs for this or do we want to IR docs involved? similar question regarding PX, do you have a PX contact to give the px-approved label here?

I don't. feature freeze team add these px/qe/docs-approved by ourselves.

[openshift-ci-robot]

@QiWang19: This pull request references Jira Issue OCPBUGS-17975, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reopen #346 Support both icsp and idms as openshift/cluster-image-registry-operator#891 will fix the rbac permission issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[flavianmissi]

/jira refresh

[openshift-ci-robot]

@flavianmissi: This pull request references Jira Issue OCPBUGS-17975, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xiuwang

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@QiWang19: Jira Issue OCPBUGS-17975: All pull requests linked via external trackers have merged:

• openshift/image-registry#375

Jira Issue OCPBUGS-17975 has been moved to the MODIFIED state.

In response to this:

Reopen #346 Support both icsp and idms as openshift/cluster-image-registry-operator#891 will fix the rbac permission issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.