Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1789687: the env ROUTER_IP_V4_V6_MODE should uses v6 instead v6_only #350

Merged
merged 1 commit into from
Jan 11, 2020

Conversation

lihongan
Copy link
Contributor

@lihongan lihongan commented Jan 10, 2020

fix Bug https://bugzilla.redhat.com/show_bug.cgi?id=1789687.

The router template uses "v6" to match the env.

    {{- else if eq "v6" $router_ip_v4_v6_mode }}
  bind :::{{env "ROUTER_SERVICE_HTTP_PORT" "80"}} v6only

see: https://github.com/openshift/router/blob/8af16cfb1e7bb1a0acf89f96c4e18529d591ec4d/images/router/haproxy/conf/haproxy-config.template#L152

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 10, 2020
@openshift-ci-robot
Copy link
Contributor

@lihongan: This pull request references Bugzilla bug 1789687, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1789687: the env ROUTER_IP_V4_V6_MODE should uses v6 instead v6_only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2020
@openshift-ci-robot
Copy link
Contributor

@lihongan: This pull request references Bugzilla bug 1789687, which is valid.

In response to this:

Bug 1789687: the env ROUTER_IP_V4_V6_MODE should uses v6 instead v6_only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lihongan
Copy link
Contributor Author

/test e2e-aws

@ironcladlou
Copy link
Contributor

/approve

Thanks!

@Miciah PTAL?

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2020
@Miciah
Copy link
Contributor

Miciah commented Jan 10, 2020

Thanks! I must have confused the HAProxy parameter with the haproxy-config.template parameter.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, lihongan, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a11c8f1 into openshift:master Jan 11, 2020
@openshift-ci-robot
Copy link
Contributor

@lihongan: All pull requests linked via external trackers have merged. Bugzilla bug 1789687 has been moved to the MODIFIED state.

In response to this:

Bug 1789687: the env ROUTER_IP_V4_V6_MODE should uses v6 instead v6_only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah
Copy link
Contributor

Miciah commented Jan 13, 2020

/cherry-pick release-4.3

@openshift-cherrypick-robot

@Miciah: #350 failed to apply on top of branch "release-4.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	pkg/operator/controller/ingress/deployment.go
M	pkg/operator/controller/ingress/deployment_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/controller/ingress/deployment_test.go
CONFLICT (content): Merge conflict in pkg/operator/controller/ingress/deployment_test.go
Auto-merging pkg/operator/controller/ingress/deployment.go
CONFLICT (content): Merge conflict in pkg/operator/controller/ingress/deployment.go
Patch failed at 0001 Bug 1789687: the env ROUTER_IP_V4_V6_MODE should uses v6 instead v6_only

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants