Bug 1805224: Add support for AWS China region route53 Service #361
Conversation
openshift-ci-robot
added
the
size/S
|
/approve |
openshift-ci-robot
added
the
approved
wanghaoran1988
force-pushed
the
route53_china
branch
2 times, most recently
from
2f8c2a8
to
f0dcb26
Compare
|
@iranzo @abhinavdahiya Comments addressed, could you take another look? |
|
/retest |
there is a inconsistency in how we are generating aws config. // places that directly create or set aws.Config struct // places that use functions to create or update aws.Config it just seems odd, any reason why it's that and why we cannot just use one way? |
wanghaoran1988
force-pushed
the
route53_china
branch
from
f0dcb26
to
85657e6
Compare
All updated to use functions |
|
/retest |
|
/retest |
wanghaoran1988
force-pushed
the
route53_china
branch
from
85657e6
to
a36dbd6
Compare
|
LGTM |
|
Thank you all for working through this. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, wanghaoran1988 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ironcladlou
changed the title
|
@wanghaoran1988: All pull requests linked via external trackers have merged. Bugzilla bug 1805224 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.4 |
|
@ironcladlou: new pull request created: #367 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.