Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1809667: Tune AWS load balancers to be consistent with other platforms #370

Merged
merged 1 commit into from Mar 6, 2020
Merged

Bug 1809667: Tune AWS load balancers to be consistent with other platforms #370

merged 1 commit into from Mar 6, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #363

/assign Miciah

@smarterclayton
Tune AWS load balancers to be consistent with other platforms
f60c65c 
GCP and Azure both hardcode LB timeouts - set AWS to match the
lower bound of Azure (2 failures @ 5s interval, 2 healthy).
By default AWS is 6 failures @ 10s which is a very long timeout
for the router.

In the future, if these attributes become customizable on GCP and
Azure, they should be consistent with our AWS settings.
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.4] Tune AWS load balancers to be consistent with other platforms

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 3, 2020
Merged
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 3, 2020
@Miciah
Copy link
Contributor

Miciah commented Mar 3, 2020

/retitle Bug 1809667: Tune AWS load balancers to be consistent with other platforms

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Tune AWS load balancers to be consistent with other platforms Bug 1809667: Tune AWS load balancers to be consistent with other platforms Mar 3, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 3, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1809667, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.0) matches configured target release for branch (4.4.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1809665 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1809665 targets the "4.5.0" release, matching the expected (4.5.0) release
  • bug has dependents

In response to this:

Bug 1809667: Tune AWS load balancers to be consistent with other platforms

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ironcladlou
Copy link
Contributor

/lgtm
/approve
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2020
@knobunc knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 6, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0ced6d4 into openshift:release-4.4 Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knobunc knobunc Awaiting requested review from knobunc

@Miciah Miciah Awaiting requested review from Miciah

Assignees

@ironcladlou ironcladlou

@Miciah Miciah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @openshift-ci-robot @Miciah @ironcladlou @openshift-bot @knobunc @openshift-merge-robot @smarterclayton