Adds Wildcard Admission Policy #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/hold
openshift-ci-robot
added
the
approved
ironcladlou
reviewed
Mar 27, 2020
ironcladlou
reviewed
Mar 27, 2020
ironcladlou
reviewed
Mar 27, 2020
danehans
force-pushed
the
wildcard_policy
branch
from
f52710e
to
dc9df20
Compare
|
Once rebased on openshift/api#607 this lgtm |
danehans
force-pushed
the
wildcard_policy
branch
from
dc9df20
to
a99895e
Compare
|
Also /hold until PR is rebased on #384. |
danehans
force-pushed
the
wildcard_policy
branch
from
a99895e
to
fbe56c7
Compare
|
/test e2e-aws-operator |
danehans
force-pushed
the
wildcard_policy
branch
from
fbe56c7
to
2569b49
Compare
|
#384 has merged. |
openshift-ci-robot
removed
the
do-not-merge/hold
Miciah
reviewed
Apr 1, 2020
danehans
force-pushed
the
wildcard_policy
branch
from
2569b49
to
e6fcaba
Compare
Miciah
reviewed
Apr 2, 2020
danehans
force-pushed
the
wildcard_policy
branch
from
e6fcaba
to
197dbd3
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Wildcard Admission Policy enhancement proposal.
/assign @ironcladlou @knobunc
/cc @Miciah @frobware
/hold until openshift/api#607 merges.