Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps k8s and openshift/api deps #384

Merged
merged 1 commit into from Apr 1, 2020
Merged

Bumps k8s and openshift/api deps #384

merged 1 commit into from Apr 1, 2020

Conversation

danehans
Copy link
Contributor

In support of the Wildcard Admission Policy feature.

/assign @ironcladlou @knobunc
/cc @Miciah @frobware

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2020
@danehans danehans mentioned this pull request Mar 30, 2020
Merged
@danehans
Copy link
Contributor Author

no 'cli' image was tagged into the stable-initial stream, that image is required for building a release

/test e2e-aws-upgrade

@ironcladlou
Copy link
Contributor

Something I've been meaning to add for a while which will hopefully give us more confidence in quickly merging these changes: #385

@ironcladlou
Copy link
Contributor

@danehans if you want to double-check your output based on my script and remove the hold please feel free, I don't want to block you.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2020
@ironcladlou
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2020
@danehans
Copy link
Contributor Author

/test e2e-aws-upgrade

@danehans
Copy link
Contributor Author

/test verify

@Miciah
Copy link
Contributor

Miciah commented Mar 31, 2020

/lgtm
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, ironcladlou, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Miciah,danehans,ironcladlou]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 963eb01 into openshift:master Apr 1, 2020
@danehans danehans deleted the k8s_1.18_bump branch April 1, 2020 16:37
This was referenced Apr 2, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frobware frobware Awaiting requested review from frobware

@Miciah Miciah Awaiting requested review from Miciah

Assignees

@ironcladlou ironcladlou

@Miciah Miciah

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@danehans @ironcladlou @Miciah @openshift-ci-robot @knobunc @openshift-merge-robot