New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1835025: TestRouteAdmissionPolicy: Wait for rolling update #396
Bug 1835025: TestRouteAdmissionPolicy: Wait for rolling update #396
Conversation
Fix test code to output the error value if a client Get call fails. * test/e2e/operator_test.go (TestRouteAdmissionPolicy): Log errors from Get.
@Miciah: This pull request references Bugzilla bug 1835025, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Miciah: This pull request references Bugzilla bug 1835025, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
83a2e97
to
9847993
Compare
Poll the ingress controller's deployment after changing the route admission policy to make sure that the deployment is updated and rolled out before checking that the new policy is in effect. This commit fixes bug 1835025. https://bugzilla.redhat.com/show_bug.cgi?id=1835025 * test/e2e/operator_test.go (TestRouteAdmissionPolicy): Add polling to make sure that the ingress controller deployment is updated and rolled out.
9847993
to
17c6350
Compare
Provisioning failure:
/test e2e-aws-operator |
Now a bunch of unrelated tests are failing:
/test e2e-aws-operator |
I tested these changes manually and could not reproduce the failures that I see in CI. It looks like the API was flaking out during the last two CI runs. /retest |
I'm seeing the same CI issues with other PRs. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Miciah: All pull requests linked via external trackers have merged: openshift/cluster-ingress-operator#396. Bugzilla bug 1835025 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
TestRouteAdmissionPolicy
: Log error ifGet
failsFix test code to output the error value if a client
Get
call fails.test/e2e/operator_test.go
(TestRouteAdmissionPolicy
): Log errors fromGet
.TestRouteAdmissionPolicy
: Wait for rolling updatePoll the ingress controller's deployment after changing the route admission policy to make sure that the deployment is updated and rolled out before checking that the new policy is in effect.
test/e2e/operator_test.go
(TestRouteAdmissionPolicy
): Add polling to make sure that the ingress controller deployment is updated and rolled out.@danehans