Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1835025: TestRouteAdmissionPolicy: Wait for rolling update #396

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented May 13, 2020

TestRouteAdmissionPolicy: Log error if Get fails

Fix test code to output the error value if a client Get call fails.

  • test/e2e/operator_test.go (TestRouteAdmissionPolicy): Log errors from Get.

TestRouteAdmissionPolicy: Wait for rolling update

Poll the ingress controller's deployment after changing the route admission policy to make sure that the deployment is updated and rolled out before checking that the new policy is in effect.

  • test/e2e/operator_test.go (TestRouteAdmissionPolicy): Add polling to make sure that the ingress controller deployment is updated and rolled out.

@danehans

Fix test code to output the error value if a client Get call fails.

* test/e2e/operator_test.go (TestRouteAdmissionPolicy): Log errors from
Get.
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 13, 2020
@openshift-ci-robot
Copy link
Contributor

@Miciah: This pull request references Bugzilla bug 1835025, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1835025: TestRouteAdmissionPolicy: Wait for rolling update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2020
@openshift-ci-robot
Copy link
Contributor

@Miciah: This pull request references Bugzilla bug 1835025, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1835025: TestRouteAdmissionPolicy: Wait for rolling update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah Miciah force-pushed the BZ1835025-TestRouteAdmissionPolicy-wait-for-rolling-update branch 2 times, most recently from 83a2e97 to 9847993 Compare May 13, 2020 00:40
Poll the ingress controller's deployment after changing the route admission
policy to make sure that the deployment is updated and rolled out before
checking that the new policy is in effect.

This commit fixes bug 1835025.

https://bugzilla.redhat.com/show_bug.cgi?id=1835025

* test/e2e/operator_test.go (TestRouteAdmissionPolicy): Add polling to make
sure that the ingress controller deployment is updated and rolled out.
@Miciah Miciah force-pushed the BZ1835025-TestRouteAdmissionPolicy-wait-for-rolling-update branch from 9847993 to 17c6350 Compare May 13, 2020 00:41
@Miciah
Copy link
Contributor Author

Miciah commented May 13, 2020

Provisioning failure:

level=error msg="Error: error adding EC2 Internet Gateway (igw-0d67dac6db5bf0579) tags: error tagging resource (igw-0d67dac6db5bf0579): InvalidInternetGatewayID.NotFound: The internetGateway ID 'igw-0d67dac6db5bf0579' does not exist"
level=error msg="\tstatus code: 400, request id: e6e5805e-e517-44d3-8618-636334854a79"
level=error
level=error msg="  on ../tmp/openshift-install-760643315/vpc/vpc-public.tf line 1, in resource \"aws_internet_gateway\" \"igw\":"
level=error msg="   1: resource \"aws_internet_gateway\" \"igw\" {"

/test e2e-aws-operator

@Miciah
Copy link
Contributor Author

Miciah commented May 13, 2020

Now a bunch of unrelated tests are failing:

=== RUN   TestUpdateDefaultIngressController
--- FAIL: TestUpdateDefaultIngressController (12.38s)
    operator_test.go:270: failed to reset default ingresscontroller: Operation cannot be fulfilled on ingresscontrollers.operator.openshift.io "default": the object has been modified; please apply your changes to the latest version and try again
    operator_test.go:285: [...]
    operator_test.go:286: failed to observe update of default ingress CA certificate configmap: timed out waiting for the condition
=== RUN   TestIngressControllerScale
I0513 02:46:46.814858    5492 request.go:621] Throttling request took 1.048175858s, request: GET:https://api.ci-op-yvmg6y2h-43abb.origin-ci-int-aws.dev.rhcloud.com:6443/apis/samples.operator.openshift.io/v1?timeout=32s
--- FAIL: TestIngressControllerScale (123.19s)
    operator_test.go:352: failed waiting deployment openshift-ingress-operator/default to scale to 3: failed to achieve expected replicas, last observed: 2
=== RUN   TestDefaultIngressCertificate
--- FAIL: TestDefaultIngressCertificate (0.59s)
    operator_test.go:476: failed to connect to router at a72437dc539304ac3a44fb26b3483d5f-1326268633.us-west-2.elb.amazonaws.com:443: x509: certificate is valid for www.example.com, not test.apps.ci-op-yvmg6y2h-43abb.origin-ci-int-aws.dev.rhcloud.com

/test e2e-aws-operator

@Miciah
Copy link
Contributor Author

Miciah commented May 13, 2020

I tested these changes manually and could not reproduce the failures that I see in CI. It looks like the API was flaking out during the last two CI runs.

/retest

@danehans
Copy link
Contributor

I'm seeing the same CI issues with other PRs.

@danehans
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2020
@openshift-merge-robot openshift-merge-robot merged commit 184f681 into openshift:master May 14, 2020
@openshift-ci-robot
Copy link
Contributor

@Miciah: All pull requests linked via external trackers have merged: openshift/cluster-ingress-operator#396. Bugzilla bug 1835025 has been moved to the MODIFIED state.

In response to this:

Bug 1835025: TestRouteAdmissionPolicy: Wait for rolling update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants