Bug 1809354: dns: Avoid unnecessary updates

[Miciah]

dns: Avoid spuriously updating a DNSRecord's status

• pkg/operator/controller/dns/controller.go (Reconcile): Use the new dnsZoneStatusSlicesEqual function to check whether an update is needed, and skip the update if it not.
  (publishRecordToZones): Use the new mergeStatuses function to merge the new zone statuses into the existing ones.
  (mergeStatuses): New function. Merge a slice of updated zone statuses into a slice of old zone statuses, using the new mergeConditions function.
  (clock): New variable.
  (mergeConditions): New function. Merge a slice of updated zone status conditions into an slice of old status conditions, using conditionChanged.
  (conditionChanged): New function. Return a Boolean value indicating whether two zone status conditions should be considered equal.
  (dnsZoneStatusSlicesEqual): New function. Return a Boolean value indicating whether two slices of zone statuses should be considered equal for the purpose of determining whether a status update is needed.
• pkg/operator/controller/dns/controller_test.go (TestPublishRecordToZonesMergesStatus): New test. Verify that publishRecordToZones correctly merges status updates.
  (TestDnsZoneStatusSlicesEqual): New test. Verify that dnsZoneStatusSlicesEqual behaves correctly.

dns: Log success or failure to publish record

• pkg/operator/controller/dns/controller.go (publishRecordToZones): Log success or failure to publish the DNS record to a given DNS zone.

Bump openshift/api for DNSRecord observedGeneration

Bump to github.com/openshift/api@17ada6e4245b4cc7a1f81ec04228e9093ec4f89e to get DNSRecordStatus's ObservedGeneration field.

• go.mod: Bump.
• go.sum:
• manifests/00-custom-resource-definition-internal.yaml:
• pkg/manifests/bindata.go:
• vendor/*: Regenerate.

dns: Avoid publishing already published DNSRecords

When publishing a DNSRecord to a zone, check its status to determine whether the DNSRecord is already published to that zone, and if it is, skip publishing it to that zone.

• pkg/operator/controller/dns/controller.go (Reconcile): Update the DNSRecord's observed generation.
  (publishRecordToZones): Use the observed generation and the new recordIsAlreadyPublishedToZone function to skip publishing the DNSRecord to a zone if the DNSRecord has previously been observed and its status conditions indicate that it is already published to the zone.
  (recordIsAlreadyPublishedToZone): New function. Use the provided DNSRecord's status to determine whether the DNSRecord is already published to the provided zone.
• pkg/operator/controller/dns/controller_test.go (TestRecordIsAlreadyPublishedToZone): New test.

dns/aws: Delete record caching

Delete caching in the DNS provider implementation for AWS now that the DNS controller uses the DNSRecord's status to avoid performing unnecessary updates.

• pkg/dns/aws/dns.go (Provider): Delete the updatedRecords field.
  (NewProvider): Delete initialization of updatedRecords.
  (change): Delete updating of updatedRecords.

[ironcladlou]

As discussed offline: this doesn't address a perhaps bigger problem which is that we're still unnecessarily updating the cloud provider every time because we're not comparing spec to status to identify diffs. If we did, not only would we only update the cloud provider when we think there's a change to be made, we could remove the AWS provider's internal caching logic.

We also discussed how when Ensure() fails, we should only update the condition last transition time if the condition has a material change, and in the face of repeated failures, we should log events so that a timeline of failure can be established.

[openshift-ci-robot]

@Miciah: This pull request references Bugzilla bug 1809354, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

WIP: Bug 1809354: dns: Avoid unnecessary updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@Miciah: This pull request references Bugzilla bug 1809354, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

WIP: Bug 1809354: dns: Avoid unnecessary updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Miciah]

The test failure should be resolved by #396.

/test e2e-aws-operator

This change should also fix https://bugzilla.redhat.com/show_bug.cgi?id=1837324.

/retitle Bug 1809354, 1837324: dns: Avoid unnecessary updates

[openshift-ci-robot]

@Miciah: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug 1809354, 1837324: dns: Avoid unnecessary updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Miciah]

Apparently support for linking multiple bugs was never merged.

/retitle Bug 1809354: dns: Avoid unnecessary updates

[openshift-ci-robot]

@Miciah: This pull request references Bugzilla bug 1809354, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1809354: dns: Avoid unnecessary updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Miciah]

I forgot that the reason that this was marked WIP was that it was blocked on openshift/api#644.

/retitle WIP: Bug 1809354: dns: Avoid unnecessary updates

[danehans]

@Miciah regarding #390 (comment), yes that's my understanding. Then the go.mod/go.sum in this PR needs to be updated to use openshift/api instead of your modified version.

[openshift-ci-robot]

@Miciah: This pull request references Bugzilla bug 1809354, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1809354: dns: Avoid unnecessary updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Miciah]

Rebased onto github.com/openshift/api@17ada6e4245b4cc7a1f81ec04228e9093ec4f89e.

[Miciah]

Rebased to resolve a conflict in bindata.go from #401.

[danehans]

error: unable to parse image registry.svc.ci.openshift.org/ci-op-qxhzdvvc/stable@sha256:bc679512a4ddcf2d7b433ed99b0ef3014ec167cddfcba95079b38aae5e28d0ef: cannot retrieve image configuration for manifest sha256:bc679512a4ddcf2d7b433ed99b0ef3014ec167cddfcba95079b38aae5e28d0ef: received unexpected HTTP status: 503 Service Unavailable

/retest

[Miciah]

I added a test case to TestPublishRecordToZonesMergesStatus to make sure we have complete coverage of mergeConditions (thanks @sgreene570!).

[danehans]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Miciah,danehans]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@Miciah: All pull requests linked via external trackers have merged: openshift/api#644, openshift/cluster-ingress-operator#390. Bugzilla bug 1809354 has been moved to the MODIFIED state.

In response to this:

Bug 1809354: dns: Avoid unnecessary updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.