[release-4.6] Bug 1891626: Support changing ingresscontroller load balancer scope #482

openshift-cherrypick-robot · 2020-10-28T19:18:31Z

This is an automated cherry-pick of #472

/assign Miciah

Add support for changing ingresscontroller load balancer scope. On AWS and IBM cloud, this requires deleting the existing load balancer service and recreating it with the desired scope. On Azure and GCP, it suffices to update the existing service's annotations. This commit also adds logic to remove the service finalizer, which is no longer needed to clean up DNS records since the DNSRecord CRD was added. * pkg/operator/controller/ingress/controller.go (setDefaultPublishingStrategy): Update scope if needed. * pkg/operator/controller/ingress/load_balancer_service.go (externalLBAnnotations): New variable. Map platform type to the annotation for that platform that makes the load balancer external, if the platform requires an explicit annotation. (ensureLoadBalancerService): Add delete and update logic. Use the new deleteLoadBalancerServiceFinalizer method to delete any finalizer on any existing service. Use the new createLoadBalancerService, deleteLoadBalancerService, and updateLoadBalancerService methods to create, update, or delete the service as needed. (desiredLoadBalancerService): Delete logic to add a finalizer to the service. Use new externalLBAnnotations variable to simplify logic. (finalizeLoadBalancerService): Refactor to use the new deleteLoadBalancerServiceFinalizer method. (createLoadBalancerService, deleteLoadBalancerService): New methods. (updateLoadBalancerService): New methods. Update the LoadBalancer service, using the new loadBalancerServiceChanged function. (loadBalancerServiceScopeChanged): New function. Check if the load balancer's scope changed. (loadBalancerServiceChanged): New function. Check if the current service needs to be updated, and if so, whether it needs to be modified or deleted and recreated. (deleteLoadBalancerServiceFinalizer): New method. Delete any finalizer from the service. * pkg/operator/controller/ingress/load_balancer_service_test.go (TestLoadBalancerServiceChanged): New test. (TestLoadBalancerServiceChangedScopeNeedsRecreate): New test. * test/e2e/operator_test.go (isServiceInternal): New function. Return a Boolean value indicating whether the provided service is annotated to request an internal load-balancer. (TestScopeChange): New test. Verify that mutating scope from the default external scope to internal scope and from internal back to external succeeds on AWS, Azure, GCP, and IBM Cloud. Co-authored-by: Dan Mace <ironcladlou@gmail.com>

openshift-ci-robot · 2020-10-28T19:18:40Z

@openshift-cherrypick-robot: Bugzilla bug 1891625 has been cloned as Bugzilla bug 1892447. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1892447: Support changing ingresscontroller load balancer scope

In response to this:

[release-4.6] Bug 1891625: Support changing ingresscontroller load balancer scope

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-10-28T19:19:02Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1892447, which is invalid:

expected dependent Bugzilla bug 1891625 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 1892447: Support changing ingresscontroller load balancer scope

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2020-10-28T19:49:57Z

/retitle [release-4.6] Bug 1891626: Support changing ingresscontroller load balancer scope

openshift-ci-robot · 2020-10-28T19:50:17Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1891626, which is invalid:

expected the bug to target the "4.6.z" release, but it targets "---" instead
expected Bugzilla bug 1891626 to depend on a bug targeting a release in 4.7.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 1891626: Support changing ingresscontroller load balancer scope

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2020-10-28T19:51:06Z

/bugzilla refresh

openshift-ci-robot · 2020-10-28T19:51:09Z

@Miciah: This pull request references Bugzilla bug 1891626, which is invalid:

expected Bugzilla bug 1891626 to depend on a bug targeting a release in 4.7.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2020-10-28T19:51:39Z

/bugzilla refresh

openshift-ci-robot · 2020-10-28T19:51:43Z

@Miciah: This pull request references Bugzilla bug 1891626, which is invalid:

expected dependent Bugzilla bug 1891625 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sgreene570 · 2020-11-04T14:14:04Z

/retest

sgreene570 · 2020-11-04T20:44:30Z

/lgtm

openshift-bot · 2020-11-05T01:01:00Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-05T01:01:05Z

@openshift-bot: This pull request references Bugzilla bug 1891626, which is invalid:

expected dependent Bugzilla bug 1891625 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-06T01:00:49Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-06T01:00:53Z

@openshift-bot: This pull request references Bugzilla bug 1891626, which is invalid:

expected dependent Bugzilla bug 1891625 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-07T01:00:50Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-07T01:00:54Z

@openshift-bot: This pull request references Bugzilla bug 1891626, which is invalid:

expected dependent Bugzilla bug 1891625 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-08T01:01:07Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-08T01:01:10Z

@openshift-bot: This pull request references Bugzilla bug 1891626, which is invalid:

expected dependent Bugzilla bug 1891625 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-09T01:01:07Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-09T01:01:11Z

@openshift-bot: This pull request references Bugzilla bug 1891626, which is invalid:

expected dependent Bugzilla bug 1891625 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-10T01:00:48Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-10T01:00:52Z

@openshift-bot: This pull request references Bugzilla bug 1891626, which is invalid:

expected dependent Bugzilla bug 1891625 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-11T01:01:12Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-11T01:01:16Z

@openshift-bot: This pull request references Bugzilla bug 1891626, which is invalid:

expected dependent Bugzilla bug 1891625 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-12T01:00:25Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-12T01:00:37Z

@openshift-bot: This pull request references Bugzilla bug 1891626, which is invalid:

expected dependent Bugzilla bug 1891625 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lihongan · 2020-11-12T06:38:16Z

/bugzilla refresh

openshift-ci-robot · 2020-11-12T06:38:22Z

@lihongan: This pull request references Bugzilla bug 1891626, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1891625 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1891625 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lihongan · 2020-11-12T06:38:36Z

/bugzilla cc-qa

openshift-ci-robot · 2020-11-12T06:38:41Z

@lihongan: This pull request references Bugzilla bug 1891626, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1891625 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1891625 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

Requesting review from QA contact:
/cc @lihongan

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lihongan · 2020-11-16T09:57:58Z

/lgtm
see also https://bugzilla.redhat.com/show_bug.cgi?id=1891626#c3 (follow PR pre-merge testing)

openshift-ci-robot · 2020-11-16T09:58:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lihongan, openshift-cherrypick-robot, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sgreene570]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-11-19T23:43:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-11-20T00:46:56Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/cluster-ingress-operator#482

Bugzilla bug 1891626 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1891626: Support changing ingresscontroller load balancer scope

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

smarterclayton · 2020-12-04T21:07:38Z

This broke clusters that were created in 4.1 - we will be blocking upgrade to 4.6.6 with openshift/cincinnati-graph-data#577 and tracking it in https://bugzilla.redhat.com/show_bug.cgi?id=1904582

openshift-ci-robot assigned Miciah Oct 28, 2020

openshift-cherrypick-robot mentioned this pull request Oct 28, 2020

Bug 1891625: Support changing ingresscontroller load balancer scope #472

Merged

openshift-ci-robot requested review from danehans and sgreene570 October 28, 2020 19:18

openshift-ci-robot changed the title ~~[release-4.6] Bug 1891625: Support changing ingresscontroller load balancer scope~~ [release-4.6] Bug 1892447: Support changing ingresscontroller load balancer scope Oct 28, 2020

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 28, 2020

dustman9000 mentioned this pull request Oct 28, 2020

Support Updating Existing IngressController openshift/cloud-ingress-operator#118

Closed

openshift-ci-robot changed the title ~~[release-4.6] Bug 1892447: Support changing ingresscontroller load balancer scope~~ [release-4.6] Bug 1891626: Support changing ingresscontroller load balancer scope Oct 28, 2020

openshift-ci-robot assigned sgreene570 Nov 4, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 4, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 12, 2020

openshift-ci-robot requested a review from lihongan November 12, 2020 06:38

openshift-ci-robot assigned lihongan Nov 16, 2020

ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 19, 2020

openshift-merge-robot merged commit 63d34d4 into openshift:release-4.6 Nov 20, 2020

Miciah mentioned this pull request Dec 8, 2020

Bug 1905490: Revert "Support changing ingresscontroller load balancer scope" #507

Merged

[release-4.6] Bug 1891626: Support changing ingresscontroller load balancer scope #482

[release-4.6] Bug 1891626: Support changing ingresscontroller load balancer scope #482

Conversation

openshift-cherrypick-robot commented Oct 28, 2020

openshift-ci-robot commented Oct 28, 2020

openshift-ci-robot commented Oct 28, 2020

Miciah commented Oct 28, 2020

openshift-ci-robot commented Oct 28, 2020

Miciah commented Oct 28, 2020

openshift-ci-robot commented Oct 28, 2020

Miciah commented Oct 28, 2020

openshift-ci-robot commented Oct 28, 2020

sgreene570 commented Nov 4, 2020

sgreene570 commented Nov 4, 2020

openshift-bot commented Nov 5, 2020

openshift-ci-robot commented Nov 5, 2020

openshift-bot commented Nov 6, 2020

openshift-ci-robot commented Nov 6, 2020

openshift-bot commented Nov 7, 2020

openshift-ci-robot commented Nov 7, 2020

openshift-bot commented Nov 8, 2020

openshift-ci-robot commented Nov 8, 2020

openshift-bot commented Nov 9, 2020

openshift-ci-robot commented Nov 9, 2020

openshift-bot commented Nov 10, 2020

openshift-ci-robot commented Nov 10, 2020

openshift-bot commented Nov 11, 2020

openshift-ci-robot commented Nov 11, 2020

openshift-bot commented Nov 12, 2020

openshift-ci-robot commented Nov 12, 2020

lihongan commented Nov 12, 2020

openshift-ci-robot commented Nov 12, 2020

lihongan commented Nov 12, 2020

openshift-ci-robot commented Nov 12, 2020

lihongan commented Nov 16, 2020

openshift-ci-robot commented Nov 16, 2020

openshift-bot commented Nov 19, 2020

openshift-ci-robot commented Nov 20, 2020

smarterclayton commented Dec 4, 2020