Bug 1896923: Configure operator metrics handler to use localhost #490
Conversation
Configure the operator's metrics handler to listen on 127.0.0.1 only. Before this commit, metrics were exposed on port 60000, without authentication. Although the pod spec does not advertise port 60000, the port was still accessible outside the pod. After this commit, port 60000 is inaccessible outside the pod, so the only way to get metrics is by connecting to port 9393 and authenticating with kube-rbac-proxy. This commit is related to bug 1896923. https://bugzilla.redhat.com/show_bug.cgi?id=1896923 * cmd/ingress-operator/start.go (NewStartCommand): Configure metrics to listen on 127.0.0.1:60000.
openshift-ci-robot
added
the
bugzilla/severity-medium
|
@Miciah: This pull request references Bugzilla bug 1896923, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
added
the
approved
|
Thanks @Miciah ! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
15 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@Miciah: All pull requests linked via external trackers have merged: Bugzilla bug 1896923 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Configure the operator's metrics handler to listen on 127.0.0.1 only.
Before this change, metrics were exposed on port 60000, without authentication. Although the pod spec does not advertise port 60000, the port was still accessible outside the pod. After this change, port 60000 is inaccessible outside the pod, so the only way to get metrics is by connecting to port 9393 and authenticating with kube-rbac-proxy.
cmd/ingress-operator/start.go(NewStartCommand): Configure metrics to listen on 127.0.0.1:60000.