Bug 1905324: Request appropriate memory for ingress-operator container #515
Conversation
openshift-ci-robot
added
bugzilla/severity-medium
|
@rfredette: This pull request references Bugzilla bug 1905324, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rfredette
force-pushed
the
bz-1905324
branch
from
6c797df
to
3631991
Compare
|
56 MiB sounds good to me (unless anyone can think of a reason we would want to round that to the nearest multiple of 5 or 10). |
|
/test e2e-aws-operator |
|
@rfredette: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
|
|
Must-gather failed. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, rfredette The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
|
/retest Please review the full test history for this PR and help us cut down flakes. |
11 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@rfredette: All pull requests linked via external trackers have merged: Bugzilla bug 1905324 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cluster components are expected to request cpu & memory resources. ingress-operator already requested an amount of cpu time, but didn't include a memory request.
Following the guidelines here, I ran
make test-e2eagainst a cluster on AWS running a 4.7 nightly build. I queried prometheus for the metriccontainer_memory_usage_bytes{container="ingress-operator"}every 15 seconds between the start and finish of the e2e run, then I sorted the data points by memory usage to find the 90th percentile, which in my run was 53,706,752 bytes, or about 51.2MiB.Adding 10% overhead to that number produced 56.34MiB, which I rounded to 56MiB