Bug 1908758: Update AWS LB health check interval annotation #518
Conversation
Add support for updating the ingresscontroller load balancer health check interval on AWS. This commit is related to bug 1908758. https://bugzilla.redhat.com/show_bug.cgi?id=1908758 * pkg/operator/controller/ingress/load_balancer_service.go (ensureLoadBalancerService): Add update logic. Use the new createLoadBalancerService and updateLoadBalancerService methods to create or update the service as needed. (createLoadBalancerService): New method. (updateLoadBalancerService): New method. Update the LoadBalancer service, using the new loadBalancerServiceChanged function. (loadBalancerServiceChanged): New function. Check if the service.beta.kubernetes.io/aws-load-balancer-healthcheck-interval annotation changed. * pkg/operator/controller/ingress/load_balancer_service_test.go (TestLoadBalancerServiceChanged): New test.
This commit resolves BZ#1908758. See https://docs.aws.amazon.com/elasticloadbalancing/latest/network/target-group-health-checks.html for more information about NLB configurations for Load Balancer services.
openshift-ci-robot
added
the
approved
Miciah
changed the title
openshift-ci-robot
added
the
bugzilla/severity-urgent
|
@Miciah: This pull request references Bugzilla bug 1908758, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@Miciah: This pull request references Bugzilla bug 1908758, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Miciah: All pull requests linked via external trackers have merged: Bugzilla bug 1908758 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update AWS LB health check interval annotation
Add support for updating the ingresscontroller load balancer health check interval on AWS.
pkg/operator/controller/ingress/load_balancer_service.go(ensureLoadBalancerService): Add update logic. Use the newcreateLoadBalancerServiceandupdateLoadBalancerServicemethods to create or update the service as needed.(
createLoadBalancerService): New method.(
updateLoadBalancerService): New method. Update the LoadBalancer service,using the newloadBalancerServiceChangedfunction.(
loadBalancerServiceChanged): New function. Check if theservice.beta.kubernetes.io/aws-load-balancer-healthcheck-intervalannotation changed.pkg/operator/controller/ingress/load_balancer_service_test.go(TestLoadBalancerServiceChanged): New test.AWS: Set health check interval to 10s for NLBs
This change resolves BZ#1908758. See https://docs.aws.amazon.com/elasticloadbalancing/latest/network/target-group-health-checks.html for more information about NLB configurations for Load Balancer services.
Supersedes #517.