Bug 1934904: Canary: Schedule canary server pods to worker and infra nodes #564
Conversation
These API definitions are needed in pkg/operator/controller/canary/namespace.go.
assets/canary/namespace.yaml: Add the `openshift.io/node-selector` annotation to the canary namespace yaml file. This will allow the canary daemonset to schedule pods onto infra nodes (in addition to worker nodes) by overriding the default behavior. pkg/manifests/bindata.go: Regenerate. pkg/operator/controller/canary/namespace.go: Add logic to update the canary namespace resource on a cluster specifically when the namespace's node-selector annotation changes. pkg/operator/controller/canary/namespace_test.go: Add a unit test to exercise the new `canaryNamespaceChanged` function. pkg/operator/controller/canary/controller.go: Update `ensureCanaryNamespace` calling site.
assets/canary/daemonset.go: Add a nodeSelector field to the canary daemonset asset that selects linux nodes. Add a tolerations field to tolerate infra node taints, so that the canary daemonset schedules pods to worker and infra nodes only. pkg/manifests/bindata.go: Regenerate pkg/operator/controller/canary/daemonset.go: Add logic to update the canary daemonset resource on a cluster specifically when the daemonset's node selector, tolerations, or canary server image reference changes. pkg/operator/controller/canary/daemonset_test.go Add unit tests to exercise the new `canaryDaemonSetChanged` function. Canary: Update daemonset on canary server image updates
openshift-ci-robot
added
the
bugzilla/severity-high
|
@sgreene570: This pull request references Bugzilla bug 1934904, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
openshift-ci-robot
added
the
approved
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1934904, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1934904, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1934904, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1934904, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1934904, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@sgreene570: This pull request references Bugzilla bug 1934904, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla cc-qa |
|
@quarterpin: This pull request references Bugzilla bug 1934904, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm Verified via pre-merge verification workflow, more reference related to the test can be found in: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, quarterpin, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
crawford
changed the title
crawford
added
the
cherry-pick-approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@sgreene570: All pull requests linked via external trackers have merged: Bugzilla bug 1934904 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a manual cherry pick of #560, since #563 ended in merge conflicts.
vendor: Pull in openshift/api/project/v1
These API definitions are needed in pkg/operator/controller/canary/namespace.go.
Canary: Add node-selector annotation to canary namespace
assets/canary/namespace.yaml:
Add the
openshift.io/node-selectorannotation to the canary namespace yaml file. This will allow the canary daemonset to schedule pods onto infra nodes (in addition to worker nodes) by overriding the default behavior.pkg/manifests/bindata.go:
Regenerate.
pkg/operator/controller/canary/namespace.go:
Add logic to update the canary namespace resource on a cluster specifically when the namespace's node-selector annotation changes.
pkg/operator/controller/canary/namespace_test.go:
Add a unit test to exercise the new
canaryNamespaceChangedfunction.pkg/operator/controller/canary/controller.go:
Update
ensureCanaryNamespacecalling site.Canary: Add node selector and tolerations to daemonset
assets/canary/daemonset.go:
Add a nodeSelector field to the canary daemonset asset that selects linux nodes. Add a tolerations field to tolerate infra node taints, so that the canary daemonset schedules pods to worker and infra nodes only.
pkg/manifests/bindata.go:
Regenerate
pkg/operator/controller/canary/daemonset.go:
Add logic to update the canary daemonset resource on a cluster specifically when the daemonset's node selector, tolerations, or canary server image reference changes.
pkg/operator/controller/canary/daemonset_test.go
Add unit tests to exercise the new
canaryDaemonSetChangedfunction.