Bug 2007581: Change default balancing algorithm to "leastconn" #663
Conversation
Configure OpenShift router to use the "leastconn" balancing algorithm for non-passthrough routes by default. This was the default algorithm for non-passthrough routes before it was changed to "random" in OpenShift 4.8. The "random" algorithm is expected to provide better behavior across reloads or multiple router pod replicas. However, it incurs significant memory overhead for each backend that uses it, and so we need to change the default back to "leastconn" in order to avoid excessive memory usage until we can fix the issue in HAProxy. This commit fixes bug 2007581. https://bugzilla.redhat.com/show_bug.cgi?id=2007581 * pkg/operator/controller/ingress/deployment.go (desiredRouterDeployment): Change the default balancing algorithm for non-passthrough routes to "leastconn", and allow an override to set "random". * pkg/operator/controller/ingress/deployment_test.go (TestDesiredRouterDeployment): Update to expect "leastconn". * test/e2e/operator_test.go (TestLoadBalancingAlgorithmUnsupportedConfigOverride): Update to expect "leastconn" as the default setting and verify that the override allows setting "random". Add a check that passthrough routes use "source".
openshift-ci
bot
added
the
bugzilla/severity-high
|
@Miciah: This pull request references Bugzilla bug 2007581, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/invalid-bug
openshift-ci
bot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2007581, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@Miciah: This pull request references Bugzilla bug 2007581, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@Miciah: All pull requests linked via external trackers have merged: Bugzilla bug 2007581 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.9 |
|
@frobware: new pull request created: #667 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Configure OpenShift router to use the "leastconn" balancing algorithm for non-passthrough routes by default.
This was the default algorithm for non-passthrough routes before it was changed to "random" in OpenShift 4.8. The "random" algorithm is expected to provide better behavior across reloads or multiple router pod replicas. However, it incurs significant memory overhead for each backend that uses it, and so we need to change the default back to "leastconn" in order to avoid excessive memory usage until we can fix the issue in HAProxy.
pkg/operator/controller/ingress/deployment.go(desiredRouterDeployment): Change the default balancing algorithm for non-passthrough routes to "leastconn", and allow an override to set "random".pkg/operator/controller/ingress/deployment_test.go(TestDesiredRouterDeployment): Update to expect "leastconn".test/e2e/operator_test.go(TestLoadBalancingAlgorithmUnsupportedConfigOverride): Update to expect "leastconn" as the default setting and verify that the override allows setting "random". Add a check that passthrough routes use "source".