Add support for route53 in the us-isob-east-1 region + fix #754
Conversation
|
CC @rfredette for review |
| @@ -142,26 +142,31 @@ func NewProvider(config Config, operatorReleaseVersion string) (*Provider, error | |||
| elbConfig := aws.NewConfig().WithRegion(region) | |||
| tagConfig := aws.NewConfig() | |||
|
|
|||
| partition, ok := endpoints.PartitionForRegion(endpoints.DefaultPartitions(), region) | |||
| if !ok { | |||
There was a problem hiding this comment.
Not sure but did you check if partition would be nil if ok is false? The switch case would throw error in that case since it's a function call with nil reference.
There was a problem hiding this comment.
@rna-afk thanks for the review! Yes, I checked the code for PartitionForRegion in the SDK and an empty struct is returned in case of error https://github.com/aws/aws-sdk-go/blob/v1.44.6/aws/endpoints/endpoints.go#L384-L392. So it should be safe to call ID() on it, which will result in an empty string.
|
thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: r4f4, rfredette The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Providing doc ack. No doc is required for this PR. |
|
We have the buy in from dos, qe, and px. Furthermore, as we are (currently) a FF team, I should be able to apply these labels myself: /label docs-approved |
openshift-ci
bot
added
docs-approved
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@r4f4: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR is just #703 with the requested fix implemented.