OCPBUGS-1554: Bump vendored k8s libraries to 1.25 #829

gcs278 · 2022-09-20T20:37:49Z

Update k8s.io/api, k8s.io/apimachinery, k8s.io/apiserver, and k8s.io/client-go to v0.25.0 as well as sigs.k8s.io/controller-runtime to v0.13.0 which maps to the overall 1.25 kubernetes release. Also bump github.com/openshift/library-go for its 1.25 support. All other vendor updates were automatically included as a part of these updates.

pkg/operator/controller/dns/controller.go: Moved utilclock to "k8s.io/utils/clock" and added utilclocktesting "k8s.io/utils/clock/testing" as that where NewFakeClock moved into.
pkg/operator/controller/dns/controller.go: Moved utilclock to "k8s.io/utils/clock"
pkg/operator/controller/ingress/status.go: Moved utilclock to "k8s.io/utils/clock"
pkg/operator/controller/status/controller.go: Moved utilclock to "k8s.io/utils/clock"

openshift-ci-robot · 2022-09-20T20:37:56Z

@gcs278: This pull request references Jira Issue OCPBUGS-1554, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.0) matches configured target version for branch (4.12.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Update k8s.io/api, k8s.io/apimachinery, k8s.io/apiserver, and k8s.io/client-go to v0.25.0, which maps to the overall 1.25 kubernetes release. Also bump github.com/openshift/library-go for its 1.25 support. All other vendor updates were automatically included as a part of these updates.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gcs278 · 2022-09-20T21:35:26Z

/retest

gcs278 · 2022-09-20T21:42:27Z

/hold
E2E build failure I missed regarding NewFakeClock missing.

gcs278 · 2022-09-20T21:50:41Z

/unhold
NewFakeClock moved to k8s.io/utils/clock/testing

openshift-ci-robot · 2022-09-20T21:53:25Z

@gcs278: This pull request references Jira Issue OCPBUGS-1554, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.0) matches configured target version for branch (4.12.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

Update k8s.io/api, k8s.io/apimachinery, k8s.io/apiserver, and k8s.io/client-go to v0.25.0, which maps to the overall 1.25 kubernetes release. Also bump github.com/openshift/library-go for its 1.25 support. All other vendor updates were automatically included as a part of these updates.

pkg/operator/controller/dns/controller.go: Moved utilclock to "k8s.io/utils/clock" and added utilclocktesting "k8s.io/utils/clock/testing" as that where NewFakeClock moved into.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-09-20T21:55:15Z

@gcs278: This pull request references Jira Issue OCPBUGS-1554, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.0) matches configured target version for branch (4.12.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

Update k8s.io/api, k8s.io/apimachinery, k8s.io/apiserver, and k8s.io/client-go to v0.25.0, which maps to the overall 1.25 kubernetes release. Also bump github.com/openshift/library-go for its 1.25 support. All other vendor updates were automatically included as a part of these updates.

pkg/operator/controller/dns/controller.go: Moved utilclock to "k8s.io/utils/clock" and added utilclocktesting "k8s.io/utils/clock/testing" as that where NewFakeClock moved into.
pkg/operator/controller/dns/controller.go: Moved utilclock to "k8s.io/utils/clock"
pkg/operator/controller/ingress/status.go: Moved utilclock to "k8s.io/utils/clock"
pkg/operator/controller/status/controller.go: Moved utilclock to "k8s.io/utils/clock"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

frobware · 2022-09-21T07:22:25Z

You have some .idea and .envrc files committed here.

A [.envrc](https://github.com/openshift/cluster-ingress-operator/pull/829/files#diff-d33e979799a45c7c51752e9c8d96a3e452015d1a40b1e4b6ec6a98e92c4d8430) (1)
A [.idea/.gitignore](https://github.com/openshift/cluster-ingress-operator/pull/829/files#diff-21610973868a98feff98dd0460438a8a32cca1447bc8701537ec5048e0c5faeb) (8)
A [.idea/cluster-ingress-operator.iml](https://github.com/openshift/cluster-ingress-operator/pull/829/files#diff-3cc7c2f38630ac52dcd6b7a2cd0b31ba4b1ac4050d2827792eb489aee98b69c2) (9)
A [.idea/modules.xml](https://github.com/openshift/cluster-ingress-operator/pull/829/files#diff-0aae258f1732eac2acd4fcdd1af6d0737b4ec8d233136c3ba7c40b6d49aeda50) (8)
A [.idea/vcs.xml](https://github.com/openshift/cluster-ingress-operator/pull/829/files#diff-a6dab70bd0e9ffc91d8419ad52225baff3a3e7c9d8e1724f7ed6d96b661d804a) (6)

gcs278 · 2022-09-21T14:29:49Z

You have some .idea and .envrc files committed here.

@frobware I did have .idea and .envrc checked in by accident, but they have since been removed. Are you still seeing them in the commit? I can't find them.

gcs278 · 2022-09-21T14:36:48Z

Tons of CI failures, looks like ingress is not working. Will investigate.

frobware · 2022-09-21T14:50:33Z

You have some .idea and .envrc files committed here.

@frobware I did have .idea and .envrc checked in by accident, but they have since been removed. Are you still seeing them in the commit? I can't find them.

I was reading changes via email. Looking again, I don't see them in the commit.

gcs278 · 2022-09-21T15:57:54Z

/retest
Maybe this was fluke?

candita · 2022-09-21T16:10:34Z

/assign @frobware
/assign @brandisher

gcs278 · 2022-09-21T18:56:28Z

CI Failures happened again:
{Operator unavailable (IngressDoesNotHaveAvailableCondition): The "default" ingress controller is not reporting an Available status condition. Operator unavailable (IngressDoesNotHaveAvailableCondition): The "default" ingress controller is not reporting an Available status condition.}

Investigating

gcs278 · 2022-09-26T14:07:47Z

/retest

gcs278 · 2022-09-26T17:22:30Z

I don't think related, others are seeing this issue: ingress-to-oauth-server-new-connections was unreachable during disruption testing
/retest

gcs278 · 2022-09-26T20:57:45Z

/retest

suleymanakbas91 · 2022-09-27T08:16:59Z

/retest

suleymanakbas91 · 2022-09-27T12:17:34Z

/retest

gcs278 · 2022-09-27T17:53:13Z

/retest

gcs278 · 2022-09-27T20:18:01Z

The install failed...
/retest

suleymanakbas91 · 2022-09-28T08:36:14Z

/retest

suleymanakbas91 · 2022-09-28T12:12:30Z

/retest

gcs278 · 2022-09-28T15:39:32Z

/retest

gcs278 · 2022-09-28T19:51:19Z

OVNKubernetesControllerDisconnectedSouthboundDatabase failure again, and now a new pods should keep the assigned EgressIPs when being rescheduled to another node connection timeout failure, which I don't believe to be affected by cluster-ingress-operator.
/retest

gcs278 · 2022-09-28T23:20:02Z

Both OVN and the ingress-to-oauth-server-new-connections was unreachable during disruption testing type testing.
Supposedly the disruption tests are fixed, so:
/retest

suleymanakbas91 · 2022-09-29T06:33:35Z

/retest

suleymanakbas91 · 2022-09-29T10:36:19Z

/retest

brandisher · 2022-09-29T15:12:51Z

ingress-to-XXX issues again
/test e2e-gcp-ovn-serial

brandisher · 2022-09-29T19:49:01Z

etcd and ovn issues
/retest e2e-gcp-ovn-serial

openshift-ci · 2022-09-29T19:49:43Z

@brandisher: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test e2e-aws-operator
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-ovn-serial
/test images
/test unit
/test verify

The following commands are available to trigger optional jobs:

/test e2e-aws-ovn-single-node
/test e2e-azure-operator
/test e2e-azure-ovn
/test e2e-gcp-operator

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-operator
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-single-node
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-upgrade
pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-ovn
pull-ci-openshift-cluster-ingress-operator-master-e2e-gcp-ovn-serial
pull-ci-openshift-cluster-ingress-operator-master-images
pull-ci-openshift-cluster-ingress-operator-master-unit
pull-ci-openshift-cluster-ingress-operator-master-verify

In response to this:

etcd and ovn issues
/retest e2e-gcp-ovn-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

brandisher · 2022-09-29T19:51:04Z

/test e2e-gcp-ovn-serial

gcs278 · 2022-09-29T20:45:29Z

/unhold
I think we've gotten enough CI runs in. It's just stuck on know problems (OVN and disruption).

Miciah · 2022-09-29T22:23:47Z

/override ci/prow/e2e-gcp-ovn-serial

openshift-ci · 2022-09-29T22:24:05Z

@Miciah: Overrode contexts on behalf of Miciah: ci/prow/e2e-gcp-ovn-serial

In response to this:

/override ci/prow/e2e-gcp-ovn-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-09-30T00:08:09Z

/retest-required

Remaining retests: 0 against base HEAD fbe157d and 2 for PR HEAD be08afc in total

suleymanakbas91 · 2022-09-30T08:28:28Z

/retest

Miciah · 2022-09-30T15:07:33Z

/override ci/prow/e2e-gcp-ovn-serial

openshift-ci · 2022-09-30T15:08:17Z

@Miciah: Overrode contexts on behalf of Miciah: ci/prow/e2e-gcp-ovn-serial

In response to this:

/override ci/prow/e2e-gcp-ovn-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-09-30T15:08:19Z

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2022-09-30T15:13:53Z

@gcs278: All pull requests linked via external trackers have merged:

openshift/cluster-ingress-operator#829

Jira Issue OCPBUGS-1554 has been moved to the MODIFIED state.

In response to this:

Update k8s.io/api, k8s.io/apimachinery, k8s.io/apiserver, and k8s.io/client-go to v0.25.0 as well as sigs.k8s.io/controller-runtime to v0.13.0 which maps to the overall 1.25 kubernetes release. Also bump github.com/openshift/library-go for its 1.25 support. All other vendor updates were automatically included as a part of these updates.

pkg/operator/controller/dns/controller.go: Moved utilclock to "k8s.io/utils/clock" and added utilclocktesting "k8s.io/utils/clock/testing" as that where NewFakeClock moved into.
pkg/operator/controller/dns/controller.go: Moved utilclock to "k8s.io/utils/clock"
pkg/operator/controller/ingress/status.go: Moved utilclock to "k8s.io/utils/clock"
pkg/operator/controller/status/controller.go: Moved utilclock to "k8s.io/utils/clock"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from lihongan, frobware and lmzuccarelli September 20, 2022 20:38

gcs278 force-pushed the bump-k8s-1.25 branch 2 times, most recently from 89536eb to a0c1dbe Compare September 20, 2022 20:41

gcs278 mentioned this pull request Sep 20, 2022

OCPBUGS-236: Bump openshift/api for reloadInterval fix #830

Merged

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2022

gcs278 force-pushed the bump-k8s-1.25 branch from a0c1dbe to 51e070e Compare September 20, 2022 21:50

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2022

openshift-ci bot assigned brandisher and frobware Sep 21, 2022

gcs278 force-pushed the bump-k8s-1.25 branch from 51e070e to aaf1b70 Compare September 21, 2022 19:05

openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. and removed jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. labels Sep 21, 2022

brandisher mentioned this pull request Sep 28, 2022

OCPBUGS-1730: Bump vendored K8S libraries to 1.25.2 openshift/router#421

Merged

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2022

openshift-merge-robot merged commit dbefffe into openshift:master Sep 30, 2022

OCPBUGS-1554: Bump vendored k8s libraries to 1.25 #829

OCPBUGS-1554: Bump vendored k8s libraries to 1.25 #829

Conversation

gcs278 commented Sep 20, 2022 • edited Loading

openshift-ci-robot commented Sep 20, 2022

gcs278 commented Sep 20, 2022

gcs278 commented Sep 20, 2022

gcs278 commented Sep 20, 2022

openshift-ci-robot commented Sep 20, 2022

openshift-ci-robot commented Sep 20, 2022

frobware commented Sep 21, 2022

gcs278 commented Sep 21, 2022

gcs278 commented Sep 21, 2022

frobware commented Sep 21, 2022

gcs278 commented Sep 21, 2022

candita commented Sep 21, 2022

gcs278 commented Sep 21, 2022

gcs278 commented Sep 26, 2022

gcs278 commented Sep 26, 2022

gcs278 commented Sep 26, 2022

suleymanakbas91 commented Sep 27, 2022

suleymanakbas91 commented Sep 27, 2022

gcs278 commented Sep 27, 2022

gcs278 commented Sep 27, 2022

suleymanakbas91 commented Sep 28, 2022

suleymanakbas91 commented Sep 28, 2022

gcs278 commented Sep 28, 2022

gcs278 commented Sep 28, 2022

gcs278 commented Sep 28, 2022

suleymanakbas91 commented Sep 29, 2022

suleymanakbas91 commented Sep 29, 2022

brandisher commented Sep 29, 2022

brandisher commented Sep 29, 2022

openshift-ci bot commented Sep 29, 2022

brandisher commented Sep 29, 2022

gcs278 commented Sep 29, 2022

Miciah commented Sep 29, 2022

openshift-ci bot commented Sep 29, 2022

openshift-ci-robot commented Sep 30, 2022

suleymanakbas91 commented Sep 30, 2022

Miciah commented Sep 30, 2022

openshift-ci bot commented Sep 30, 2022

openshift-ci bot commented Sep 30, 2022

openshift-ci-robot commented Sep 30, 2022

gcs278 commented Sep 20, 2022 •

edited

Loading