Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.12] OCPBUGS-3517: Ingress controller should not have affinity policy in single-replica clusters #857

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #810

/assign michael-topchiev

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2022

@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: michael-topchiev.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This is an automated cherry-pick of #810

/assign michael-topchiev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-1725 has been cloned as Jira Issue OCPBUGS-3517. Retitling PR to link against new bug.
/retitle [release-4.12] OCPBUGS-3517: Ingress controller should not have affinity policy in single-replica clusters

In response to this:

This is an automated cherry-pick of #810

/assign michael-topchiev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.12] OCPBUGS-1725: Ingress controller should not have affinity policy in single-replica clusters [release-4.12] OCPBUGS-3517: Ingress controller should not have affinity policy in single-replica clusters Nov 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2022

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.12] OCPBUGS-3517: Ingress controller should not have affinity policy in single-replica clusters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 11, 2022
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-3517, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-1725 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-1725 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #810

/assign michael-topchiev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@candita
Copy link
Contributor

candita commented Dec 21, 2022

/assign @Miciah

@Miciah
Copy link
Contributor

Miciah commented Jan 17, 2023

/assign @frobware

@frobware
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2023
@frobware
Copy link
Contributor

frobware commented Jan 17, 2023

Tests last run November '22.

/retest

@Miciah
Copy link
Contributor

Miciah commented Feb 28, 2023

/approve
/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Miciah Miciah added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 5, 2023
@ShudiLi
Copy link
Member

ShudiLi commented Apr 7, 2023

From QE side, tested it with 4.12.0-0.ci.test-2023-04-07-075856-ci-ln-7g912db-latest

% oc get clusterversion
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.12.0-0.ci.test-2023-04-07-075856-ci-ln-7g912db-latest True False 4m9s Cluster version is 4.12.0-0.ci.test-2023-04-07-075856-ci-ln-7g912db-latest
%

% oc get nodes
NAME STATUS ROLES AGE VERSION
ip-10-0-138-163.us-west-2.compute.internal Ready control-plane,master,worker 30m v1.25.8+27e744f
%

% oc -n openshift-ingress get pods
NAME READY STATUS RESTARTS AGE
router-default-7cf4bc6667-7cs74 1/1 Running 3 (18m ago) 25m
%

% oc rollout restart deployment router-default -n openshift-ingress
deployment.apps/router-default restarted
%

% oc -n openshift-ingress get pods
NAME READY STATUS RESTARTS AGE
router-default-55498d7b85-hh9tv 1/1 Running 0 5s
router-default-7cf4bc6667-7cs74 1/1 Running 3 (19m ago) 26m
% oc -n openshift-ingress get pods
NAME READY STATUS RESTARTS AGE
router-default-55498d7b85-hh9tv 1/1 Running 0 63s
router-default-7cf4bc6667-7cs74 0/1 Terminating 3 (20m ago) 27m
%
% oc -n openshift-ingress get pods
NAME READY STATUS RESTARTS AGE
router-default-55498d7b85-hh9tv 1/1 Running 0 3m28s
%

/label qe-approved
thanks

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 7, 2023
@ShudiLi
Copy link
Member

ShudiLi commented Apr 10, 2023

/label cherry-pick-approved
thanks

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 10, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6f3e22f into openshift:release-4.12 Apr 10, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-3517: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-3517 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #810

/assign michael-topchiev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-ingress-operator-container-v4.12.0-202305022015.p0.g6f3e22f.assembly.stream for distgit ose-cluster-ingress-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.