Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-13049: bump controller-runtime to fix the multi namespace cache indexing #922

Merged
merged 1 commit into from Aug 8, 2023
Merged

[release-4.12] OCPBUGS-13049: bump controller-runtime to fix the multi namespace cache indexing #922

merged 1 commit into from Aug 8, 2023

Conversation

alebedev87
Copy link
Contributor

Backport of #913.

Upstream backport: kubernetes-sigs/controller-runtime#2288.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2023

@alebedev87: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.12] OCPBUGS-13049: bump controller-runtime to fix the multi namespace cache indexing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 3, 2023
@openshift-ci-robot
Copy link
Contributor

@alebedev87: This pull request references Jira Issue OCPBUGS-13049, which is invalid:

  • expected dependent Jira Issue OCPBUGS-12743 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is New instead
  • expected dependent Jira Issue OCPBUGS-12743 to target a version in 4.13.0, but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backport of #913.

Upstream backport: kubernetes-sigs/controller-runtime#2288.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from candita and miheer May 3, 2023 14:42
@alebedev87
Copy link
Contributor Author

/assign @Miciah

As the reviewer of the original PR.

@Miciah
Copy link
Contributor

Miciah commented May 30, 2023

/test e2e-aws-operator

@lihongan
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 10, 2023
@openshift-ci-robot
Copy link
Contributor

@lihongan: This pull request references Jira Issue OCPBUGS-13049, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-12743 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-12743 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from lihongan July 10, 2023 02:46
@lihongan
Copy link
Contributor

/retest-required

@Miciah
Copy link
Contributor

Miciah commented Jul 11, 2023

This is a clean cherry-pick that bumps the vendored sigs.k8s.io/controller-runtime package to pick up a low-risk but important bug fix (namely kubernetes-sigs/controller-runtime@03d09f6). This bump pulls in an unrelated commit (see kubernetes-sigs/controller-runtime@v0.13.0...ae1cde6), but it looks harmless.
/approve
/lgtm
/label backport-risk-assessed
/hold
Let #959 merge first.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Jul 11, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
@lihongan
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 13, 2023
@alebedev87
Copy link
Contributor Author

/retest

@alebedev87
Copy link
Contributor Author

/retest-required

@alebedev87
Copy link
Contributor Author

#959 merged.

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7a507e4 and 2 for PR HEAD 847e615 in total

@alebedev87
Copy link
Contributor Author

/test e2e-gcp-ovn-serial

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e56a18d and 1 for PR HEAD 847e615 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8b44d0b and 0 for PR HEAD 847e615 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 847e615 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2023
@Miciah
Copy link
Contributor

Miciah commented Aug 7, 2023

/hold cancel
/test all
since #963 and #964 have merged.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8b44d0b and 2 for PR HEAD 847e615 in total

@melvinjoseph86
Copy link

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d5fe3f4 and 1 for PR HEAD 847e615 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2023

@alebedev87: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn 847e615 link false /test e2e-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3892bb3 into openshift:release-4.12 Aug 8, 2023
9 of 10 checks passed
@openshift-ci-robot
Copy link
Contributor

@alebedev87: Jira Issue OCPBUGS-13049: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13049 has been moved to the MODIFIED state.

In response to this:

Backport of #913.

Upstream backport: kubernetes-sigs/controller-runtime#2288.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.12.0-0.nightly-2023-08-08-180645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candita candita Awaiting requested review from candita

@miheer miheer Awaiting requested review from miheer

@lihongan lihongan Awaiting requested review from lihongan

Assignees

@Miciah Miciah

@lihongan lihongan

@melvinjoseph86 melvinjoseph86

@ShudiLi ShudiLi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@alebedev87 @openshift-ci-robot @Miciah @lihongan @melvinjoseph86 @openshift-merge-robot @ShudiLi