Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-16620: Deflake TestRouterCompressionOperation #963

Merged
merged 1 commit into from Aug 7, 2023
Merged

[release-4.12] OCPBUGS-16620: Deflake TestRouterCompressionOperation #963

merged 1 commit into from Aug 7, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #920

/assign Miciah

@gcs278
OCPBUGS-12913: Deflake TestRouterCompressionOperation
7279960 
Wait for old router pods to be cleaned up before proceeding with testing
compression.

- `test/e2e/router_compression_test.go`: Use
waitForDeploymentCompleteWithOldPodTermination
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 20, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-12913 has been cloned as Jira Issue OCPBUGS-16620. Will retitle bug to link to clone.
/retitle [release-4.12] OCPBUGS-16620: Deflake TestRouterCompressionOperation

In response to this:

This is an automated cherry-pick of #920

/assign Miciah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.12] OCPBUGS-12913: Deflake TestRouterCompressionOperation [release-4.12] OCPBUGS-16620: Deflake TestRouterCompressionOperation Jul 20, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 20, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-16620, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #920

/assign Miciah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from knobunc and Miciah July 20, 2023 19:43
@Miciah
Copy link
Contributor

Miciah commented Jul 20, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 20, 2023
@openshift-ci-robot
Copy link
Contributor

@Miciah: This pull request references Jira Issue OCPBUGS-16620, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-13157 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-13157 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from lihongan July 20, 2023 19:48
@Miciah
Copy link
Contributor

Miciah commented Jul 20, 2023

/hold
Depends on #964.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2023
@Miciah Miciah mentioned this pull request Jul 20, 2023
Merged
@lihongan
Copy link
Contributor

lihongan commented Aug 3, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 3, 2023
@Miciah
Copy link
Contributor

Miciah commented Aug 3, 2023

/hold cancel
now that #964 has merged.
/test all

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@Miciah
Copy link
Contributor

Miciah commented Aug 3, 2023

e2e-gcp-ovn-serial failed because [sig-arch] events should not repeat pathologically failed:

{  1 events happened too frequently

event happened 21 times, something is wrong: node/ci-op-c709jysf-7b4ae-q5xw8-worker-c-2hzlk - reason/ErrorReconcilingNode roles/worker [k8s.ovn.org/node-chassis-id annotation not found for node ci-op-c709jysf-7b4ae-q5xw8-worker-c-2hzlk, macAddress annotation not found for node "ci-op-c709jysf-7b4ae-q5xw8-worker-c-2hzlk" , k8s.ovn.org/l3-gateway-config annotation not found for node "ci-op-c709jysf-7b4ae-q5xw8-worker-c-2hzlk"]}

I believe this is OCPBUGS-10841.
/test e2e-gcp-ovn-serial

@Miciah
Copy link
Contributor

Miciah commented Aug 3, 2023

e2e-gcp-ovn-serial failed again with the same failure.
/test e2e-gcp-ovn-serial

@Miciah
Copy link
Contributor

Miciah commented Aug 4, 2023

e2e-gcp-ovn-serial failed again, same failure.
/test e2e-gcp-ovn-serial

@Miciah
Copy link
Contributor

Miciah commented Aug 5, 2023

/approve
/lgtm

The backport is low-risk as it only modifies an E2E test.
/label backport-risk-assessed

e2e-gcp-ovn-serial failed because [sig-arch] events should not repeat pathologically failed:

{  1 events happened too frequently

event happened 21 times, something is wrong: node/ci-op-yfxvnn10-7b4ae-dqv54-worker-f-r6mdv - reason/ErrorReconcilingNode roles/worker [k8s.ovn.org/node-chassis-id annotation not found for node ci-op-yfxvnn10-7b4ae-dqv54-worker-f-r6mdv, macAddress annotation not found for node "ci-op-yfxvnn10-7b4ae-dqv54-worker-f-r6mdv" , k8s.ovn.org/l3-gateway-config annotation not found for node "ci-op-yfxvnn10-7b4ae-dqv54-worker-f-r6mdv"]}

This is a known issue: OCPBUGS-10841.
/test e2e-gcp-ovn-serial

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 5, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e56a18d and 2 for PR HEAD 7279960 in total

@Miciah
Copy link
Contributor

Miciah commented Aug 6, 2023

e2e-gcp-ovn-serial failed again because of the same issue.
/test e2e-gcp-ovn-serial

@Miciah
Copy link
Contributor

Miciah commented Aug 6, 2023

e2e-gcp-ovn-serial failed again, same issue.
/test e2e-gcp-ovn-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8b44d0b into openshift:release-4.12 Aug 7, 2023
10 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-16620: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16620 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #920

/assign Miciah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah Miciah mentioned this pull request Aug 7, 2023
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.12.0-0.nightly-2023-08-07-170227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knobunc knobunc Awaiting requested review from knobunc

@Miciah Miciah Awaiting requested review from Miciah

@lihongan lihongan Awaiting requested review from lihongan

Assignees

@Miciah Miciah

@lihongan lihongan

@melvinjoseph86 melvinjoseph86

@ShudiLi ShudiLi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @openshift-ci-robot @Miciah @lihongan @openshift-merge-robot @melvinjoseph86 @ShudiLi @gcs278