Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug 1949306: add deprecated CRD manifest #1102

Merged
merged 2 commits into from
Apr 14, 2021
Merged

bug 1949306: add deprecated CRD manifest #1102

merged 2 commits into from
Apr 14, 2021

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 13, 2021

simple rebase of #1097 since normal work hours are over

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2021
@deads2k deads2k changed the title add deprecated CRD manifest bug 1949306: add deprecated CRD manifest Apr 13, 2021
@openshift-ci-robot
Copy link

@deads2k: This pull request references Bugzilla bug 1949306, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

bug 1949306: add deprecated CRD manifest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 13, 2021
@deads2k deads2k mentioned this pull request Apr 13, 2021
Closed
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

mfojtik
mfojtik reviewed Apr 14, 2021
View reviewed changes
bindata/v4.1.0/kube-apiserver/apiserver.openshift.io_deprecatedapirequests.yaml
- name: v1
schema:
openAPIV3Schema:
description: DeprecatedAPIRequest tracts requests made to a deprecated API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tracks ?

mfojtik
mfojtik reviewed Apr 14, 2021
View reviewed changes
bindata/v4.1.0/kube-apiserver/apiserver.openshift.io_deprecatedapirequests.yaml
description: spec defines the characteristics of the resource.
type: object
properties:
removedRelease:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: removedInRelease reads better

mfojtik
mfojtik reviewed Apr 14, 2021
View reviewed changes
bindata/v4.1.0/kube-apiserver/apiserver.openshift.io_deprecatedapirequests.yaml
type: string
maxLength: 64
minLength: 3
pattern: ^[0-9][0-9]*\.[0-9][0-9]*$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this allows 99.99 right? so the max length here is 5 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure the * allows as many as you like.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least one digit on each side.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mfojtik
Copy link
Contributor

mfojtik commented Apr 14, 2021

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor Author

deads2k commented Apr 14, 2021

The job runs are failing after passes of the tests themselves

Gathering console logs for i-05b4a73e34ca258fd
'ascii' codec can't encode character '\u2026' in position 13825: ordinal not in range(128)
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"prow/entrypoint/run.go:80","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2021-04-14T13:29:45Z"}
error: failed to execute wrapped command: exit status 1

Which is a known problem during collection, but not impacting the tests. See https://coreos.slack.com/archives/CBN38N3MW/p1618410403100400

/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-upgrade
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-operator

passing job runs are

  1. https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-kube-apiserver-operator/1102/pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws-serial/1382254558310305792
  2. https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-kube-apiserver-operator/1102/pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-upgrade/1382293842832658432
  3. https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-kube-apiserver-operator/1102/pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws/1382303390985359360

@openshift-ci-robot
Copy link

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-aws, ci/prow/e2e-aws-operator, ci/prow/e2e-aws-serial, ci/prow/e2e-upgrade

In response to this:

The job runs are failing after passes of the tests themselves

Gathering console logs for i-05b4a73e34ca258fd
'ascii' codec can't encode character '\u2026' in position 13825: ordinal not in range(128)
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"prow/entrypoint/run.go:80","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2021-04-14T13:29:45Z"}
error: failed to execute wrapped command: exit status 1

Which is a known problem during collection, but not impacting the tests. See https://coreos.slack.com/archives/CBN38N3MW/p1618410403100400

/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-upgrade
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-operator

passing job runs are

  1. https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-kube-apiserver-operator/1102/pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws-serial/1382254558310305792
  2. https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-kube-apiserver-operator/1102/pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-upgrade/1382293842832658432
  3. https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-kube-apiserver-operator/1102/pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws/1382303390985359360

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit a40e631 into openshift:master Apr 14, 2021
@openshift-ci-robot
Copy link

@deads2k: All pull requests linked via external trackers have merged:

Bugzilla bug 1949306 has been moved to the MODIFIED state.

In response to this:

bug 1949306: add deprecated CRD manifest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 16, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 24, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik mfojtik left review comments

@sanchezl sanchezl sanchezl left review comments

@sttts sttts Awaiting requested review from sttts

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees

@mfojtik mfojtik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deads2k @openshift-ci-robot @openshift-bot @mfojtik @sanchezl @openshift-merge-robot