Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPNODE-1890: Bump k8s api to v0.29.0 #1586

Merged
merged 1 commit into from Dec 18, 2023
Merged

OCPNODE-1890: Bump k8s api to v0.29.0 #1586

merged 1 commit into from Dec 18, 2023

Conversation

sairameshv
Copy link
Member

cc: @soltysh

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 22, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sairameshv sairameshv changed the title Bump to k8s v1.29 OCPNODE-1890: Bump k8s api to v0.29.0-alpha.3 Nov 22, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 22, 2023 •
edited by openshift-ci bot

@sairameshv: This pull request references OCPNODE-1890 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

cc: @soltysh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 22, 2023
soltysh
soltysh requested changes Nov 28, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@sairameshv sairameshv changed the title OCPNODE-1890: Bump k8s api to v0.29.0-alpha.3 OCPNODE-1890: Bump k8s api to v0.29.0-rc.1 Nov 29, 2023
@sairameshv sairameshv marked this pull request as ready for review November 29, 2023 07:12
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2023
@sairameshv
Copy link
Member Author

/retest

@sairameshv sairameshv marked this pull request as draft November 29, 2023 16:49
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2023
@sairameshv sairameshv marked this pull request as ready for review November 30, 2023 12:52
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2023
@openshift-ci openshift-ci bot requested a review from soltysh November 30, 2023 12:59
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2023
@sairameshv sairameshv changed the title OCPNODE-1890: Bump k8s api to v0.29.0-rc.1 OCPNODE-1890: Bump k8s api to v0.29.0 Dec 18, 2023
@sairameshv
Bump k8s api to v0.29.0
a0d19eb 
Signed-off-by: Sai Ramesh Vanka <svanka@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2023
soltysh
soltysh approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sairameshv, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0d8c2dc and 2 for PR HEAD a0d19eb in total

@soltysh
Copy link
Member

soltysh commented Dec 18, 2023

/retest-required

1 similar comment
@soltysh
Copy link
Member

soltysh commented Dec 18, 2023

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

@sairameshv: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-single-node a0d19eb link false /test e2e-gcp-operator-single-node
ci/prow/e2e-metal-single-node-live-iso a0d19eb link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-aws-operator-disruptive-single-node a0d19eb link false /test e2e-aws-operator-disruptive-single-node
ci/prow/k8s-e2e-gcp-serial a0d19eb link false /test k8s-e2e-gcp-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 439b6a5 into openshift:master Dec 18, 2023
11 of 15 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.16.0-202312190117.p0.g439b6a5.assembly.stream for distgit ose-cluster-kube-apiserver-operator.
All builds following this will include this PR.

@sairameshv sairameshv deleted the rebase-1.29 branch December 19, 2023 07:20
@soltysh soltysh mentioned this pull request Dec 19, 2023
Merged
openshift-merge-bot bot added a commit that referenced this pull request Dec 19, 2023
@openshift-merge-bot
Merge pull request #1607 from soltysh/wip
420a0e9 
TRT-1420: revert #1586 #1596
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

@tkashem tkashem Awaiting requested review from tkashem

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sairameshv @openshift-ci-robot @soltysh @openshift-bot @openshift-merge-robot