Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRT-1420: revert #1586 #1596 #1607

Merged
merged 3 commits into from Dec 19, 2023
Merged

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Dec 19, 2023

This reverts commits from #1586 and #1596

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2023
@soltysh
Copy link
Member Author

soltysh commented Dec 19, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2023
@soltysh soltysh changed the title Wip TRT-1420: revert #1586 #1596 Dec 19, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 19, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2023

@soltysh: This pull request references TRT-1420 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Member Author

soltysh commented Dec 19, 2023

/hold cancel

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2023

@soltysh: This pull request references TRT-1420 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This reverts commits from #1586 and #1596

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2023
@dgoodwin
Copy link

/override ci/prow/e2e-aws-operator-disruptive-single-node
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-operator
/override ci/prow/k8s-e2e-gcp-serial

/approve
/lgtm

Going back to suspected good state.

Copy link
Contributor

openshift-ci bot commented Dec 19, 2023

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-aws-operator-disruptive-single-node, ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-operator, ci/prow/k8s-e2e-gcp-serial

In response to this:

/override ci/prow/e2e-aws-operator-disruptive-single-node
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-operator
/override ci/prow/k8s-e2e-gcp-serial

/approve
/lgtm

Going back to suspected good state.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2023
Copy link
Contributor

openshift-ci bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 420a0e9 into openshift:master Dec 19, 2023
14 of 15 checks passed
Copy link
Contributor

openshift-ci bot commented Dec 19, 2023

@soltysh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-single-node b43289c link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.16.0-202312191650.p0.g420a0e9.assembly.stream for distgit ose-cluster-kube-apiserver-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants