Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: certrotationcontroller: set AutoRegenerateAfterOfflineExpiry #1652

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Mar 5, 2024

This annotation ensures that the component certificates will be automatically regenerated when the cluster is offline (suspended or shutdown).
openshift/release#49238 will ensure these tests are being run

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2024
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
Copy link
Contributor

openshift-ci bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dinhxuanvu,vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dinhxuanvu
Copy link
Member

Failed test looks unrelated to the changes
/retest-required

@vrutkovs vrutkovs changed the title certrotationcontroller: set AutoRegenerateAfterOfflineExpiry NO-JIRA: certrotationcontroller: set AutoRegenerateAfterOfflineExpiry Mar 5, 2024
@openshift-ci-robot
Copy link

@vrutkovs: This pull request explicitly references no jira issue.

In response to this:

This annotation ensures that the component certificates will be automatically regenerated when the cluster is offline (suspended or shutdown).
openshift/release#49238 will ensure these tests are being run

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 5, 2024
@dinhxuanvu
Copy link
Member

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2f8d114 and 2 for PR HEAD 6f3faa4 in total

@vrutkovs
Copy link
Member Author

vrutkovs commented Mar 6, 2024

/test e2e-aws-ovn-serial

@vrutkovs
Copy link
Member Author

vrutkovs commented Mar 6, 2024

/test k8s-e2e-gcp

Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/k8s-e2e-gcp-serial 6f3faa4 link false /test k8s-e2e-gcp-serial
ci/prow/e2e-aws-operator-disruptive-single-node 6f3faa4 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-aws-ovn-single-node 6f3faa4 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-operator-single-node 6f3faa4 link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e6cba0a into openshift:master Mar 6, 2024
11 of 15 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.16.0-202403061739.p0.ge6cba0a.assembly.stream.el9 for distgit ose-cluster-kube-apiserver-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants