NO-ISSUE: Revert "certrotationcontroller: set AutoRegenerateAfterOfflineExpiry for generated certificates

[p0lyn0mial]

This reverts commit 6f3faa4 introduced in #1652

We have multiple controllers reconciling the same resource at the same time without any coordination.
For example the kube-control-plane-signer-ca configmap is synced by 4 controllers (actually it is 8 because we have 2 processes).

Since the mentioned PR added a distinct annotation (AutoRegenerateAfterOfflineExpiry) for the same configmap it caused a hot update loop since the configmap was different.

The conflict error can be seen even on a successful run but usually it causes the CI jobs to fail..

Since the issue is common I decided to revert as it might even block CI payloads from merging.

It should also unblock #1659

We should stop adding more changes to the cert rotation controllers until we resolve the race.

[p0lyn0mial]

/assign @vrutkovs

[openshift-ci-robot]

@p0lyn0mial: This pull request explicitly references no jira issue.

In response to this:

This reverts commit 6f3faa4 introduced in #1652

We have multiple controllers reconciling the same resource at the same time without any coordination.
For example the kube-control-plane-signer-ca configmap is synced by 4 controllers (actually it is 8 because we have 2 processes).

Since the mentioned PR added a distinct annotation (AutoRegenerateAfterOfflineExpiry) for the same configmap it caused a hot update loop since the configmap was different.

The conflict error can be seen even on a successful run but usually it causes the CI jobs to fail..

Since the issue is common I decided to revert as it might even block CI payloads from merging.

It should also unblock #1659

We should stop adding more changes to the cert rotation controllers until we resolve the race.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vrutkovs]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [p0lyn0mial,vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[p0lyn0mial]

ci/prow/k8s-e2e-gcp and ci/prow/e2e-gcp-operator failed on cluster installation, logs are missing and it looks like loki wasn't set up either.

[p0lyn0mial]

/retest-required

[openshift-ci]

@p0lyn0mial: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-operator-single-node	5823d3d	link	false	/test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node	5823d3d	link	false	/test e2e-aws-operator-disruptive-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.16.0-202404040915.p0.g7ae9875.assembly.stream.el9 for distgit ose-cluster-kube-apiserver-operator.
All builds following this will include this PR.