Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPCLOUD-2513: Remove cloud-provider and cloud-config flags #1656

Closed
wants to merge 0 commits into from

Conversation

nrb
Copy link

@nrb nrb commented Mar 12, 2024

Remove cloud-provider and cloud-config arguments from the Kube API server invocation. These flags are depecrated and will be an error to call later.

Note: to be grouped with openshift/library-go#1692

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 12, 2024

@nrb: This pull request references OCPCLOUD-2513 which is a valid jira issue.

In response to this:

Remove cloud-provider and cloud-config arguments from the Kube API server invocation. These flags are depecrated and will be an error to call later.

Note: to be grouped with openshift/library-go#1692

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2024
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@nrb
Copy link
Author

nrb commented Mar 12, 2024

@nrb nrb marked this pull request as ready for review April 2, 2024 16:36
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2024
@openshift-ci openshift-ci bot requested review from benluddy and tkashem April 2, 2024 16:38
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2024
@nrb
Copy link
Author

nrb commented May 21, 2024

/retest

quay was returning 500s, which is unrelated to the changes.

Copy link
Contributor

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nrb
Copy link
Author

nrb commented May 22, 2024

#1666 included the necessary changes.

Copy link
Contributor

openshift-ci bot commented May 22, 2024

@nrb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-encryption-perf-aescbc bd762c3 link false /test e2e-gcp-operator-encryption-perf-aescbc
ci/prow/e2e-gcp-operator-encryption-aesgcm bd762c3 link false /test e2e-gcp-operator-encryption-aesgcm
ci/prow/e2e-gcp-operator-encryption-single-node bd762c3 link false /test e2e-gcp-operator-encryption-single-node
ci/prow/e2e-gcp-operator-encryption-perf-aesgcm bd762c3 link false /test e2e-gcp-operator-encryption-perf-aesgcm
ci/prow/e2e-gcp-operator-encryption-rotation-single-node bd762c3 link false /test e2e-gcp-operator-encryption-rotation-single-node
ci/prow/e2e-gcp-operator-encryption-rotation-aesgcm bd762c3 link false /test e2e-gcp-operator-encryption-rotation-aesgcm
ci/prow/e2e-gcp-operator-encryption-rotation-aescbc bd762c3 link false /test e2e-gcp-operator-encryption-rotation-aescbc
ci/prow/e2e-gcp-operator-encryption-perf-single-node bd762c3 link false /test e2e-gcp-operator-encryption-perf-single-node
ci/prow/e2e-gcp-operator-encryption-aescbc bd762c3 link false /test e2e-gcp-operator-encryption-aescbc
ci/prow/e2e-metal-single-node-live-iso 04eba64 link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-gcp-operator-single-node 04eba64 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node 04eba64 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-aws-ovn-single-node 04eba64 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants