Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPCLOUD-2513: Remove cloud-provider, cloud-config, and cloud-volume-plugin flags #799

Closed
wants to merge 2 commits into from

Conversation

nrb
Copy link
Contributor

@nrb nrb commented Mar 12, 2024

Remove cloud-provider, cloud-config and cloud-volume-plugin flags from the Kubernetes controller manager invocation. These flags are depecrated and will be an error to call later.

Note: to be grouped with openshift/library-go#1692

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 12, 2024

@nrb: This pull request references OCPCLOUD-2513 which is a valid jira issue.

In response to this:

Remove cloud-provider, cloud-config and cloud-volume-plugin flags from the Kubernetes controller manager invocation. These flags are depecrated and will be an error to call later.

Note: to be grouped with openshift/library-go#1692

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2024
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nrb
Once this PR has been reviewed and has the lgtm label, please assign mfojtik for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nrb added 2 commits March 29, 2024 14:02
The following flags were removed as they are depecrated and will
eventually create an error when used.

* --cloud-config
* --cloud-provider
* --cloud-volume-plugin
* --configure-cloud-routes

Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2024
@nrb nrb marked this pull request as ready for review April 2, 2024 16:35
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2024
Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

@nrb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-deps 7efb7a6 link true /test verify-deps
ci/prow/e2e-aws-operator 7efb7a6 link true /test e2e-aws-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingvagabund
Copy link
Member

Let's wait until openshift/library-go#1692 merges.

@soltysh
Copy link
Member

soltysh commented May 15, 2024

Replaced with #806

@soltysh soltysh closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants