OCPBUGS-31384: use RotatedSigningCASecret controller in update only mode #1659
Conversation
|
/cc @p0lyn0mial |
|
/hold (until openshift/kubernetes#1924 merges) |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
the
approved
|
|
||
| // we will remove this when we migrate all of the affected secret | ||
| // objects to their intended type: https://issues.redhat.com/browse/API-1800 | ||
| UseSecretUpdateOnly: true, |
There was a problem hiding this comment.
we should also apply it to the RotatedSelfSignedCertKeySecret controller, right ?
we will remove this when we migrate all of the affected secret objects to their intended type see: https://issues.redhat.com/browse/API-1800
tkashem
force-pushed
the
secret-hack-4.16
branch
from
7f9ee74
to
b07a384
Compare
tkashem
changed the title
openshift-ci-robot
added
jira/severity-critical
|
@tkashem: This pull request references Jira Issue OCPBUGS-31384, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
/retest-required |
|
it also requires openshift/kubernetes#1929 |
|
/retest-required |
|
/lgtm |
|
/cc @vrutkovs |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/retest |
|
/retest-required |
|
/retest-required |
1 similar comment
|
/retest-required |
|
in general due to the platform's long history (spanning several years) |
|
issues like |
|
/retest-required #1661 merged which should unblock all jobs except |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@tkashem: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 7599746
into
openshift:master
|
@tkashem: Jira Issue OCPBUGS-31384: Some pull requests linked via external trackers have merged:
The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-31384 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.16.0-202404041616.p0.g7599746.assembly.stream.el9 for distgit ose-cluster-kube-apiserver-operator. |
UseSecretUpdateOnly is intended as a short term hack for a very specific use case,
and it works in tandem with a particular carry patch applied to the openshift kube-apiserver.
(openshift/kubernetes#1924)
we will remove this when we migrate all of the affected secret
objects to their intended type: https://issues.redhat.com/browse/API-1800
in short tls secrets used by this operator are reconciled by multiple controllers at the same time without any coordination. the issue is that the secret's crypto material can be regenerated, which has serious consequences for the platform as it can break external clients and the cluster itself.
xref: openshift/library-go#1705
xref: openshift/kubernetes#1924