Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-32241: [release-4.12] dashboard: use recording rules for most metrics #1667

Open
wants to merge 6 commits into
base: release-4.12
Choose a base branch
from
Open

OCPBUGS-32241: [release-4.12] dashboard: use recording rules for most metrics #1667

wants to merge 6 commits into from

Conversation

vrutkovs
Copy link
Member

Add more recording rules to reduce the load on Thanos querier and Prometheus.

This removes "auto" interval as it can't be cached via recording rules.

Cherrypick of #1611 on release-4.12

@vrutkovs
dashboard: use recording rules for most metrics
ccad76a 
Add more recording rules to reduce the load on Thanos querier and Prometheus.

This removes "auto" interval as it can't be cached via recording rules
@vrutkovs
manifests: remove unnecessary v2 suffix in dashboard name
6c8f73c
@vrutkovs
manifests: add new PrometheusRule for recording rules
205d658 
Move recording rules out of `kube-apiserver` PrometheusRule as it is being removed by CVO (has "delete" annotation)
@vrutkovs
manifests: add openshift-oauth-apiserver on API Servers dashboard
e0d14fc 
Update recording rules to include openshift-oauth-apiserver too
@vrutkovs
manifests: don't include recording rules when console is disabled
f72ddb1 
In order to avoid additional load on Prometheus the recording rules for kube-apiserver dashboard are not included when Console capability is not enablked . These are not used anywhere else, so it should not affect any other components.
@vrutkovs
manifests: rename API performance dashboard
27bd18d 
In previous PR this manifests was labelled as "available only when Console capability enabled". This causes CVO to force enable Console capability when upgrading from baseline 4.13 cluster - as this manifest is present.

In order to avoid this, the manifest needs to be renamed, so that CVO would treat it as a new one (since its applicability has changed)
@vrutkovs
Copy link
Member Author

/jira cherrypick OCPBUGS-25922

@openshift-ci-robot
Copy link

@vrutkovs: Jira Issue OCPBUGS-25922 has been cloned as Jira Issue OCPBUGS-32241. Will retitle bug to link to clone.
/retitle OCPBUGS-32241: [release-4.12] dashboard: use recording rules for most metrics

In response to this:

/jira cherrypick OCPBUGS-25922

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.12] dashboard: use recording rules for most metrics OCPBUGS-32241: [release-4.12] dashboard: use recording rules for most metrics Apr 15, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 15, 2024
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-32241, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected dependent Jira Issue OCPBUGS-25922 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add more recording rules to reduce the load on Thanos querier and Prometheus.

This removes "auto" interval as it can't be cached via recording rules.

Cherrypick of #1611 on release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 15, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-single-node 27bd18d link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node 27bd18d link false /test e2e-aws-operator-disruptive-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 20, 2024
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-32241, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-25922 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-25922 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @wangke19

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 20, 2024
@openshift-ci openshift-ci bot requested a review from wangke19 May 20, 2024 07:49
@p0lyn0mial
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees

@p0lyn0mial p0lyn0mial

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vrutkovs @openshift-ci-robot @p0lyn0mial