Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-32241: [release-4.12] dashboard: use recording rules for most metrics #1667

Open
wants to merge 6 commits into
base: release-4.12
Choose a base branch
from
Open

OCPBUGS-32241: [release-4.12] dashboard: use recording rules for most metrics #1667

wants to merge 6 commits into from

Commits on Apr 15, 2024

  1. dashboard: use recording rules for most metrics 

    Add more recording rules to reduce the load on Thanos querier and Prometheus.

This removes "auto" interval as it can't be cached via recording rules
    @vrutkovs
    vrutkovs committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    ccad76a View commit details
    Browse the repository at this point in the history

  2. manifests: remove unnecessary v2 suffix in dashboard name

    @vrutkovs
    vrutkovs committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    6c8f73c View commit details
    Browse the repository at this point in the history

  3. manifests: add new PrometheusRule for recording rules 

    Move recording rules out of `kube-apiserver` PrometheusRule as it is being removed by CVO (has "delete" annotation)
    @vrutkovs
    vrutkovs committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    205d658 View commit details
    Browse the repository at this point in the history

  4. manifests: add openshift-oauth-apiserver on API Servers dashboard 

    Update recording rules to include openshift-oauth-apiserver too
    @vrutkovs
    vrutkovs committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    e0d14fc View commit details
    Browse the repository at this point in the history

  5. manifests: don't include recording rules when console is disabled 

    In order to avoid additional load on Prometheus the recording rules for kube-apiserver dashboard are not included when Console capability is not enablked . These are not used anywhere else, so it should not affect any other components.
    @vrutkovs
    vrutkovs committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    f72ddb1 View commit details
    Browse the repository at this point in the history

  6. manifests: rename API performance dashboard 

    In previous PR this manifests was labelled as "available only when Console capability enabled". This causes CVO to force enable Console capability when upgrading from baseline 4.13 cluster - as this manifest is present.

In order to avoid this, the manifest needs to be renamed, so that CVO would treat it as a new one (since its applicability has changed)
    @vrutkovs
    vrutkovs committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    27bd18d View commit details
    Browse the repository at this point in the history