Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch operator to use protobuf client for non-CR resources #250

Merged
merged 2 commits into from
Feb 12, 2019
Merged

Switch operator to use protobuf client for non-CR resources #250

merged 2 commits into from
Feb 12, 2019

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Feb 12, 2019

This builds on openshift/library-go#233 and switches the controller loops that deal with non-CR resources to client-go with protobuf enforced.

/cc @deads2k
/cc @smarterclayton

NOTE: Remove the artificial bump before merging.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 12, 2019
@soltysh
Copy link
Member

soltysh commented Feb 12, 2019

Surprisingly fast green, do you have data before and after this change?

@mfojtik
Copy link
Contributor Author

mfojtik commented Feb 12, 2019 •
edited

Hrm, the openshift-config namespace seems to be missing...

/retest

@mfojtik mfojtik force-pushed the operator-proto branch 3 times, most recently from 63c539a to 4f60bf8 Compare February 12, 2019 14:27
@mfojtik mfojtik changed the title WIP: Switch operator to use protobuf client for non-CR resources Switch operator to use protobuf client for non-CR resources Feb 12, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2019
deads2k
deads2k reviewed Feb 12, 2019
View reviewed changes
pkg/operator/starter.go Outdated
@@ -29,7 +29,7 @@ import (
)

func RunOperator(ctx *controllercmd.ControllerContext) error {
kubeClient, err := kubernetes.NewForConfig(ctx.KubeConfig)
protoKubeClient, err := kubernetes.NewForConfig(ctx.ProtoKubeConfig)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't rename this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@mfojtik
Copy link
Contributor Author

mfojtik commented Feb 12, 2019

Fixed client rename, LGTM per Slack from @deads2k

@mfojtik mfojtik added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 12, 2019
@mfojtik
Copy link
Contributor Author

mfojtik commented Feb 12, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2019
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfojtik mfojtik added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2019
@mfojtik
Copy link
Contributor Author

mfojtik commented Feb 12, 2019

Re-applied LGTM as the only change was a panic fix in library-go.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2019
@mfojtik mfojtik added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2019
@openshift-merge-robot openshift-merge-robot merged commit 372d2a2 into openshift:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mfojtik @soltysh @openshift-bot @openshift-ci-robot @deads2k @openshift-merge-robot