Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultconfig: bump http2-max-streams-per-connection to 2000 #332

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Mar 8, 2019

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 8, 2019
@mfojtik
Copy link
Contributor Author

mfojtik commented Mar 8, 2019

@sttts @deads2k looks like this flag makes apiserver to crash loop...

@deads2k
Copy link
Contributor

deads2k commented Mar 8, 2019

@sttts @deads2k looks like this flag makes apiserver to crash loop...

got a log?

…ate apiserver issues with too many configs or pods
@mfojtik mfojtik force-pushed the bump-http2-max-streams-per-connection branch from 5c377df to 0b3a965 Compare March 8, 2019 13:19
@deads2k
Copy link
Contributor

deads2k commented Mar 8, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ffbc882 into openshift:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants