encryption: e2e w/ real controllers against real cluster with fake deployer #614
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
sttts
force-pushed
the
sttts-encryption-integration-test
branch
from
f051870
to
2ea54b3
Compare
sttts
force-pushed
the
sttts-encryption-integration-test
branch
from
0f0de1b
to
530ca73
Compare
sttts
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
Unrelated flakes. /retest |
|
Infra. |
| eventRecorder := events.NewLoggingEventRecorder(component) | ||
| deployer := NewInstantDeployer(stopCh, kubeInformers, kubeClient.CoreV1(), fmt.Sprintf("encryption-config-%s", component)) | ||
|
|
||
| controllers, err := encryption.NewControllers( |
There was a problem hiding this comment.
Can the following set up influence the real ka-o working in a cluster? I think that at least both controllers will watch the same secrets. Note that in the future encryption will be on by default.
There was a problem hiding this comment.
the component is different (=> different secrets), and I use another operator config and fake APIServer config, for that reason to separate it.
sttts
force-pushed
the
sttts-encryption-integration-test
branch
from
530ca73
to
33c8413
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This allows us to run exhaustive e2e tests without the 20min slow-down of the static-pod deployer per key rotation.