Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alert for deprecated apis #625

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Add alert for deprecated apis #625

merged 2 commits into from
Oct 29, 2019

Conversation

tnozicka
Copy link
Contributor

/cc @soltysh

/hold
(just in case, I think this should fail on current offenders)

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 23, 2019
@tnozicka
Copy link
Contributor Author

tnozicka commented Oct 23, 2019 •
edited
Loading

I have manually checked that the alerts are present in the prometheus dump from the CI run - that should have failed aws-e2e - monitoring team is working on a fix. We should merge when the check is fixed, we get really green e2e and no alerts are firing. (Also means making the offenders to fix their code.)

/hold

@tnozicka
Copy link
Contributor Author

e2e fix in openshift/origin#24005

soltysh
soltysh approved these changes Oct 24, 2019
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit/question.
/lgtm

manifests/0000_90_kube-apiserver-operator_04_servicemonitor-apiserver.yaml Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2019
@tnozicka
Copy link
Contributor Author

/test e2e-aws

@tnozicka tnozicka force-pushed the add-alert-for-deprecated-apis branch from 51201c1 to d000195 Compare October 29, 2019 10:02
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2019
@sttts
Copy link
Contributor

sttts commented Oct 29, 2019

👍

LGTM

soltysh
soltysh approved these changes Oct 29, 2019
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tnozicka
Copy link
Contributor Author

alerts are firing in https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-kube-apiserver-operator/625/pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws/2869/artifacts/e2e-aws/metrics/prometheus.tar , the e2e that should stop merging it is green :(

@tnozicka
Copy link
Contributor Author

ok, this needs to land for feature

/hold cancel

I'll follow up with a high prio BZ to fix the e2e check; the ones for offenders are already filled

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2019
@openshift-merge-robot openshift-merge-robot merged commit 3874d5b into openshift:master Oct 29, 2019
@tnozicka
Copy link
Contributor Author

ref https://bugzilla.redhat.com/show_bug.cgi?id=1766638

@tnozicka tnozicka deleted the add-alert-for-deprecated-apis branch October 29, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tnozicka @sttts @openshift-ci-robot @soltysh @openshift-merge-robot