Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix certsyncer to use longlived localhost-recovery cert for cert-syncer #656

Merged
merged 3 commits into from
Nov 19, 2019
Merged

Fix certsyncer to use longlived localhost-recovery cert for cert-syncer #656

merged 3 commits into from
Nov 19, 2019

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Nov 13, 2019 •
edited
Loading

Took a stab at fixing #638

/cc @sttts

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 13, 2019
@tnozicka tnozicka changed the title Fix certsyncer to use recovery Fix certsyncer to use longlived localhost-recovery cert for cert-syncer Nov 13, 2019
@tnozicka
Copy link
Contributor Author

/retest

1 similar comment
@tnozicka
Copy link
Contributor Author

/retest

@tnozicka tnozicka force-pushed the fix-certsyncer-to-use-recovery branch from baee6d1 to 7a110f8 Compare November 13, 2019 18:10
@tnozicka tnozicka mentioned this pull request Nov 13, 2019
Merged
4 tasks
@tnozicka tnozicka changed the title Fix certsyncer to use longlived localhost-recovery cert for cert-syncer [WIP] - Fix certsyncer to use longlived localhost-recovery cert for cert-syncer Nov 14, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2019
@tnozicka tnozicka force-pushed the fix-certsyncer-to-use-recovery branch from 7a110f8 to bf972ad Compare November 14, 2019 12:57
@tnozicka tnozicka changed the title [WIP] - Fix certsyncer to use longlived localhost-recovery cert for cert-syncer Fix certsyncer to use longlived localhost-recovery cert for cert-syncer Nov 14, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2019
@tnozicka tnozicka force-pushed the fix-certsyncer-to-use-recovery branch 2 times, most recently from e792026 to ce6ee98 Compare November 14, 2019 16:15
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2019
@tnozicka tnozicka force-pushed the fix-certsyncer-to-use-recovery branch from b4fcde3 to 9c5e4f5 Compare November 18, 2019 14:52
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2019
@tnozicka
Copy link
Contributor Author

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 18, 2019
@tnozicka tnozicka force-pushed the fix-certsyncer-to-use-recovery branch from b0783be to fccbaeb Compare November 18, 2019 16:51
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2019
@tnozicka tnozicka changed the title Fix certsyncer to use longlived localhost-recovery cert for cert-syncer [WIP] Fix certsyncer to use longlived localhost-recovery cert for cert-syncer Nov 18, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2019
@tnozicka tnozicka force-pushed the fix-certsyncer-to-use-recovery branch from fccbaeb to 23cb15d Compare November 19, 2019 07:58
@tnozicka tnozicka changed the title [WIP] Fix certsyncer to use longlived localhost-recovery cert for cert-syncer Fix certsyncer to use longlived localhost-recovery cert for cert-syncer Nov 19, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2019
@p0lyn0mial
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 79fda66 into openshift:master Nov 19, 2019
@tnozicka tnozicka deleted the fix-certsyncer-to-use-recovery branch November 19, 2019 09:28
@tnozicka tnozicka mentioned this pull request Nov 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts Awaiting requested review from sttts

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@p0lyn0mial p0lyn0mial

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tnozicka @p0lyn0mial @openshift-ci-robot @openshift-merge-robot