-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configobservation/etcd: add exception for etcd-bootstrap to not use FQDN #673
configobservation/etcd: add exception for etcd-bootstrap to not use FQDN #673
Conversation
needs test /assign @hexfusion |
06a208e
to
5951c08
Compare
5951c08
to
c985bb7
Compare
I do not understand the error, going to try again to see if it resurfaces /test e2e-aws-operator |
/test e2e-aws-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @alaypatel07 few comments.
No change to go.mod or go sum here? Can we verify the dep changes? |
@hexfusion since the deps were sub packages of client-go and we already have it in go.mod[1] and go.sum IMO 1. cluster-kube-apiserver-operator/go.mod Line 37 in c985bb7
|
@hexfusion sure I can add the test cases. In general I assumed that ip addresses would be good because we have it from the installer and hence tested only the change in this PR |
I don't disagree but being overly defensive here isn't a bad thing. |
339f896
to
0f6dd99
Compare
@hexfusion addressed all concerns, PTAL |
/lgtm |
/test e2e-aws |
infra flake
/test e2e-aws |
/test e2e-aws Marketplace flake |
0f6dd99
to
6e7b173
Compare
6e7b173
to
a2779df
Compare
@hexfusion I addressed the deps concern. FTR, I did a @sttts addressed your concerns as well PTAL |
Infra flake
/test e2e-aws |
thanks @alaypatel07 /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alaypatel07, hexfusion, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This PR checks if the etcd-bootstrap host is configured with a real IP address
and uses it to connect to etcd instead of etcd-bootstrap FQDN. This will
relax the requirement of configuring A records in the installer for etcd-bootstrap