configobservation/etcd: add exception for etcd-bootstrap to not use FQDN

[alaypatel07]

This PR checks if the etcd-bootstrap host is configured with a real IP address
and uses it to connect to etcd instead of etcd-bootstrap FQDN. This will
relax the requirement of configuring A records in the installer for etcd-bootstrap

[deads2k]

needs test

/assign @hexfusion

[alaypatel07]

secret/support created
set -o pipefail; go test -race -v -timeout 1h -p 1 -json ./test/e2e/... | gotest2junit > /tmp/artifacts/unit_report.xml
FAIL: github.com/openshift/cluster-kube-apiserver-operator/test/e2e TestEncryptionTypeAESCBC 4m0.783s
make: *** [test-unit] Error 1
---

I do not understand the error, going to try again to see if it resurfaces

/test e2e-aws-operator

[alaypatel07]

/test e2e-aws-operator

[hexfusion]

Thanks for doing this @alaypatel07 few comments.

[hexfusion]

No change to go.mod or go sum here? Can we verify the dep changes?

[alaypatel07]

@hexfusion since the deps were sub packages of client-go and we already have it in go.mod[1] and go.sum IMO go mod vendor just downloaded those and I committed them. The ci/prow/verify test passes which means we are good with deps?

1.

cluster-kube-apiserver-operator/go.mod

Line 37 in c985bb7

k8s.io/client-go v0.0.0

[alaypatel07]

@hexfusion sure I can add the test cases. In general I assumed that ip addresses would be good because we have it from the installer and hence tested only the change in this PR

[hexfusion]

@hexfusion sure I can add the test cases. In general I assumed that ip addresses would be good because we have it from the installer and hence tested only the change in this PR

I don't disagree but being overly defensive here isn't a bad thing.

[alaypatel07]

@hexfusion addressed all concerns, PTAL

[hexfusion]

/lgtm
/approve

[alaypatel07]

/test e2e-aws

[alaypatel07]

infra flake

level=fatal msg="failed to fetch Cluster: failed to generate asset \"Cluster\": failed to create cluster: failed to apply using Terraform"

/test e2e-aws

[alaypatel07]

/test e2e-aws

Marketplace flake

[alaypatel07]

@hexfusion I addressed the deps concern. FTR, I did a go mod tidy and go mod vendor initially that brought the other dependencies in. I reset the head to HEAD~1 and just used the go mod vendor command and that fixed the concerns. PTAL

@sttts addressed your concerns as well PTAL

[alaypatel07]

Infra flake

evel=fatal msg="failed to fetch Cluster: failed to generate asset \"Cluster\": failed to create cluster: failed to apply using Terraform"

/test e2e-aws

[hexfusion]

thanks @alaypatel07

/lgtm

[sttts]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alaypatel07, hexfusion, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hexfusion]

/retest