bug 1797657: increase the max-requests limits #733
Conversation
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
|
@deads2k What are real values? Why these? |
|
/retest |
openshift-ci-robot
added
the
needs-rebase
|
The limits were chosen during 3.x pre etcd2 where we had demonstrated hard boundaries on CPU use. Based on all data I have in etcd3 period, a 3x increase is not an issue and any bug we hit where load is not effectively transferred would be a bug in the platform, not due to this. /approve |
|
Basically 1k was chosen arbitrarily based on a CPU usage number in the early 3.x time period. We have reclaimed somewhere between 5x and 10x CPU with etcd3, protobuf, improvements to internal efficiency, so a 3x bump gives us headroom without significantly increasing the risk of a failure due to excessive queries (we are likely to better respond with backpressure at multiple levels) |
deads2k
force-pushed
the
more-requests
branch
from
290110b
to
8b868b4
Compare
openshift-ci-robot
removed
the
needs-rebase
|
/retest |
|
/lgtm This will help for reasonably sized cluster. It might still not be enough for very dense clusters. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, smarterclayton, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deads2k
changed the title
|
@deads2k: This pull request references Bugzilla bug 1797657, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@deads2k: All pull requests linked via external trackers have merged. Bugzilla bug 1797657 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
more in line with real values.
/assign @smarterclayton