bug 1693951: consume the master kubelet bootstrap credential from a separate confi… #747
Conversation
…gmap for revocation
openshift-ci-robot
added
size/S
deads2k
changed the title
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@deads2k: This pull request references Bugzilla bug 1693951, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -324,6 +324,8 @@ func ManageClientCABundle(lister corev1listers.ConfigMapLister, client coreclien | |||
| resourcesynccontroller.ResourceLocation{Namespace: operatorclient.OperatorNamespace, Name: "kube-control-plane-signer-ca"}, | |||
| // this bundle is what a user uses to mint new client certs it directly manages | |||
| resourcesynccontroller.ResourceLocation{Namespace: operatorclient.TargetNamespace, Name: "user-client-ca"}, | |||
| // this bundle is what validates the master kubelet bootstrap credential. Users can invalid this by removing it. | |||
| resourcesynccontroller.ResourceLocation{Namespace: operatorclient.GlobalMachineSpecifiedConfigNamespace, Name: "kubelet-bootstrap-kubeconfig"}, | |||
There was a problem hiding this comment.
| namespace: openshift-config-managed | ||
| data: | ||
| ca-bundle.crt: | | ||
| {{ .Assets | load "kubelet-bootstrap-kubeconfig-ca-bundle.crt" | indent 4 }} |
There was a problem hiding this comment.
is this for the installer?
|
/retest Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
…gmap for revocation
implements openshift/enhancements#196