Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1794376: Remove IPv6 dualstack feature gate #758

Merged
merged 4 commits into from Feb 10, 2020
Merged

Bug 1794376: Remove IPv6 dualstack feature gate #758

merged 4 commits into from Feb 10, 2020

Conversation

mfojtik
Copy link
Member

@mfojtik mfojtik commented Feb 10, 2020

Builds on #757

tnozicka and others added 4 commits February 10, 2020 11:18
@tnozicka
Migrate to openshift/build-machinery-go
abe69eb
@tnozicka
Bump: openshift/build-machinery-go
9860800
@mfojtik
bump(*): vendor update
b8959db 
* openshift/api@a63a88e3: Bug 1769015: Add kubebuilder annotations to the network types
* openshift/api@e205a72a: Update generated files
* openshift/api@3bf8cd9d: Update swagger docs
* openshift/api@2b89f314: Call add-crd-gen in the Makefile
* openshift/api@f92f2cd9: add deprecaction notice for build pipeline strategy
* openshift/api@0bffa333: update/verify various generated
* openshift/api@1772b9d5: Remove Description from CLI output to improve its display
* openshift/api@74333963: Add CRD generator documentation to Readme
* openshift/api@60d997e9: config/v1/types_proxy: Clarify trustedCA semantics
* openshift/api@709bcf89: Bug 1784532: Clarify `from` behavior in builds
* openshift/api@38db8664: make update
* openshift/api@2dfe621f: config: disable IPv6DualStack feature flag
* openshift/library-go@a3fec49c: Remove alpha-build-machinery
* openshift/library-go@387645fc: add methods to manipulation observed configuration values
* openshift/library-go@80c146a9: Migrate to openshift/build-machinery-go
* openshift/library-go@6b4b515b: bump: openshift/build-machinery-go
* openshift/library-go@39cf0ddc: Add alpha-build-machinery warning
* openshift/library-go@9e4693a8: add substitution for NODE_NAME inside of static pods
* openshift/library-go@89976f0a: add cpu limits to become guaranteed
* openshift/library-go@58b2341b: bump(*): vendor update
* openshift/library-go@042e7f26: adjust featuregates unit test for IPv6DualStack removal
@mfojtik
config: remove ipv6 dualstack feature gate from blacklist
f62c1f8
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 10, 2020
@mfojtik mfojtik changed the title Remove IPv6 dualstack feature gate Bug 1794376: Remove IPv6 dualstack feature gate Feb 10, 2020
@mfojtik
Copy link
Member Author

mfojtik commented Feb 10, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 10, 2020
@openshift-ci-robot
Copy link

@mfojtik: This pull request references Bugzilla bug 1794376, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1794376: Remove IPv6 dualstack feature gate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@mfojtik: This pull request references Bugzilla bug 1794376, which is valid.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2020
mfojtik
mfojtik commented Feb 10, 2020
View reviewed changes
pkg/operator/configobservation/configobservercontroller/observe_config_controller.go
@@ -106,7 +105,7 @@ func NewConfigObserver(
[]string{"apiServerArguments", "cloud-config"}),
featuregates.NewObserveFeatureFlagsFunc(
nil,
sets.NewString("IPv6DualStack"), // IPv6DualStack is bugged, don't turn it on
nil,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @deads2k ... we removed that feature gate, so we don't have to black list this anymore...

soltysh
soltysh approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold
for the prereq to merge first

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2020
@mfojtik
Copy link
Member Author

mfojtik commented Feb 10, 2020

/hold cancel

@soltysh this does not need any pre-reqs

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2020
@tnozicka
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, soltysh, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tnozicka tnozicka mentioned this pull request Feb 10, 2020
Closed
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0515311 into openshift:master Feb 10, 2020
@openshift-ci-robot
Copy link

@mfojtik: All pull requests linked via external trackers have merged. Bugzilla bug 1794376 has been moved to the MODIFIED state.

In response to this:

Bug 1794376: Remove IPv6 dualstack feature gate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@sttts sttts Awaiting requested review from sttts

Assignees

@soltysh soltysh

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mfojtik @openshift-ci-robot @tnozicka @openshift-bot @soltysh @openshift-merge-robot