Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1794376: Remove IPv6 dualstack feature gate #758

Merged
merged 4 commits into from Feb 10, 2020
Merged

Bug 1794376: Remove IPv6 dualstack feature gate #758

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
abe69eb
Migrate to openshift/build-machinery-go
tnozicka Feb 10, 2020
9860800
Bump: openshift/build-machinery-go
tnozicka Feb 10, 2020
b8959db
bump(*): vendor update
mfojtik Feb 10, 2020
f62c1f8
config: remove ipv6 dualstack feature gate from blacklist
mfojtik Feb 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions pkg/operator/configobservation/configobservercontroller/observe_config_controller.go
View file
Open in desktop
@@ -1,7 +1,6 @@
package configobservercontroller

import (
"k8s.io/apimachinery/pkg/util/sets"
"k8s.io/client-go/tools/cache"

configinformers "github.com/openshift/client-go/config/informers/externalversions"
Expand Down Expand Up @@ -106,7 +105,7 @@ func NewConfigObserver(
[]string{"apiServerArguments", "cloud-config"}),
featuregates.NewObserveFeatureFlagsFunc(
nil,
sets.NewString("IPv6DualStack"), // IPv6DualStack is bugged, don't turn it on
nil,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @deads2k ... we removed that feature gate, so we don't have to black list this anymore...

[]string{"apiServerArguments", "feature-gates"},
),
network.ObserveRestrictedCIDRs,
Expand Down