Bug 1810184: Components using globs in Dockerfile COPY commands may break on OCP 4 #816
Conversation
|
@p0lyn0mial: This pull request references Bugzilla bug 1810184, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
should mirror #808 |
| COPY --from=builder /go/src/github.com/openshift/cluster-kube-apiserver-operator/bindata/bootkube/* /usr/share/bootkube/manifests/ | ||
| COPY --from=builder /go/src/github.com/openshift/cluster-kube-apiserver-operator/bindata/bootkube/bootstrap-manifests /usr/share/bootkube/manifests/bootstrap-manifests/ | ||
| COPY --from=builder /go/src/github.com/openshift/cluster-kube-apiserver-operator/bindata/bootkube/config /usr/share/bootkube/manifests/config/ | ||
| COPY --from=builder /go/src/github.com/openshift/cluster-kube-apiserver-operator/bindata/bootkube/manifests /usr/share/bootkube/manifests/manifests/ | ||
| COPY --from=builder /go/src/github.com/openshift/cluster-kube-apiserver-operator/cluster-kube-apiserver-operator /usr/bin/ | ||
| COPY manifests/*.yaml /manifests/ |
There was a problem hiding this comment.
surprise, we can't copy the whole directory as we did in master and 4.4 (COPY manifests /manifests) because it contains some JSON files to.
p0lyn0mial
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
bparees
added
bugzilla/valid-bug
|
BZ overridden: covered by automated tests, low risk, needed for api.ci migration. will let team review/lgtm. |
| @@ -5,8 +5,9 @@ ENV GO_PACKAGE github.com/openshift/cluster-kube-apiserver-operator | |||
| RUN make build --warn-undefined-variables | |||
|
|
|||
| FROM registry.svc.ci.openshift.org/ocp/4.3:base | |||
| RUN mkdir -p /usr/share/bootkube/manifests /manifests | |||
| COPY --from=builder /go/src/github.com/openshift/cluster-kube-apiserver-operator/bindata/bootkube/* /usr/share/bootkube/manifests/ | |||
There was a problem hiding this comment.
@bparees out of curiosity does it mean that in the past the directory structure for bootkube was incorrect?
There was a problem hiding this comment.
no, you were just reliant on how "docker" handles /* which is not the same as how buildah does. So it was fine as long as you were being built on docker. As we're switching CI to build things using buildah, your dockerfile would have stopped building the right thing.
There was a problem hiding this comment.
sorry, you were reliant on imagebuilder behavior, not docker. docker+buildah work the same way.
There was a problem hiding this comment.
There was a problem hiding this comment.
imagebuilder preserved the subdirs when doing a cp from foo/* whereas docker+buildah flatten the subdir when you use *
There was a problem hiding this comment.
okay, I was just wondering why CI jobs were passing despite the destination dir being different. Thanks for explaining!
crawford
changed the title
crawford
added
the
cherry-pick-approved
|
@p0lyn0mial: All pull requests linked via external trackers have merged: openshift/cluster-kube-apiserver-operator#816. Bugzilla bug 1810184 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.