Wire event watcher for LateConnections events #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* openshift/library-go@54705a04: Handle storage types in staticresourcecontroller * openshift/library-go@af23769d: eventwatch: add controller
openshift-ci-robot
added
the
do-not-merge/hold
openshift-ci-robot
added
the
approved
|
/lgtm |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
(we don't have to wait for origin, this will be no-op until that PR merge and this can get some testing cycles meanwhile ;-) |
|
/retest |
soltysh
reviewed
Jun 17, 2020
| @@ -104,6 +106,10 @@ func RunOperator(ctx context.Context, controllerContext *controllercmd.Controlle | |||
| controllerContext.EventRecorder, | |||
| ) | |||
|
|
|||
| eventWatcher := eventwatch.New(). | |||
| WithEventHandler(operatorclient.TargetNamespace, "LateConnections", terminationobserver.ProcessLateConnectionEvents). | |||
There was a problem hiding this comment.
@mfojtik who's producing this event, asking for a friend 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wire event watcher for
LateConnectionsevent that increase theopenshift_kube_apiserver_lateconnections_countprometheus metric.A follow up would be to add Prometheus Alert.
Blocked on openshift/origin#25126
/hold