-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wire event watcher for LateConnections events #887
Wire event watcher for LateConnections events #887
Conversation
* openshift/library-go@54705a04: Handle storage types in staticresourcecontroller * openshift/library-go@af23769d: eventwatch: add controller
/lgtm |
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
(we don't have to wait for origin, this will be no-op until that PR merge and this can get some testing cycles meanwhile ;-) |
/retest |
@@ -104,6 +106,10 @@ func RunOperator(ctx context.Context, controllerContext *controllercmd.Controlle | |||
controllerContext.EventRecorder, | |||
) | |||
|
|||
eventWatcher := eventwatch.New(). | |||
WithEventHandler(operatorclient.TargetNamespace, "LateConnections", terminationobserver.ProcessLateConnectionEvents). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mfojtik who's producing this event, asking for a friend 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wire event watcher for
LateConnections
event that increase theopenshift_kube_apiserver_lateconnections_count
prometheus metric.A follow up would be to add Prometheus Alert.
Blocked on openshift/origin#25126
/hold