Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add /etc/kubernetes/static-pod-certs/configmaps/control-plane-node-ku… #907

Merged

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jul 20, 2020

…beconfig/kubeconfig

This is a system:masters identity which is in known location to make it easy to always have cluster-admin credentials. Recall that if you can read the contents of this directory on disk, you already have etcd credentials, so this is not an escalation

once it is present, we can use the client-cert to wire up openshift/kubernetes#271 to pass credentials along.

/assign @sanchezl

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2020
@tnozicka
Copy link
Contributor

there is already this one #858

Copy link
Contributor

@sanchezl sanchezl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm This gets us going until #858 is done and we can use @tnozicka 's solution instead.

@sanchezl
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants